Skip to content

Commit

Permalink
- sep 15 for scrapy#629
Browse files Browse the repository at this point in the history
  • Loading branch information
AphonicChaos committed Mar 6, 2014
1 parent c0a72e9 commit 27ff010
Showing 1 changed file with 57 additions and 0 deletions.
57 changes: 57 additions & 0 deletions sep/sep-015.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
======= ==============================================
SEP 15
Title ScrapyManager and SpiderManager API refactoring
Author Insophia Team
Created 2010-03-10
Status Final
======= ==============================================

========================================================
SEP-015: ScrapyManager and SpiderManager API refactoring
========================================================

This SEP proposes a refactoring of ``ScrapyManager`` and ``SpiderManager``
APIs.

SpiderManager
=============

- ``get(spider_name)`` -> ``Spider`` instance
- ``find_by_request(request)`` -> list of spider names
- ``list()`` -> list of spider names

- remove ``fromdomain()``, ``fromurl()``

ScrapyManager
=============

- ``crawl_request(request, spider=None)``
- calls ``SpiderManager.find_by_request(request)`` if spider is ``None``
- fails if ``len(spiders returned)`` != 1
- ``crawl_spider(spider)``
- calls ``spider.start_requests()``
- ``crawl_spider_name(spider_name)``
- calls ``SpiderManager.get(spider_name)``
- calls ``spider.start_requests()``
- ``crawl_url(url)``
- calls ``spider.make_requests_from_url()``

- remove ``crawl()``, ``runonce()``

Instead of using ``runonce()``, commands (such as crawl/parse) would call
``crawl_*`` and then ``start()``.

Changes to Commands
===================

- ``if is_url(arg):``
- calls ``ScrapyManager.crawl_url(arg)``
- ``else:``
- calls ``ScrapyManager.crawl_spider_name(arg)``

Pending issues
==============

- should we rename ``ScrapyManager.crawl_*`` to ``schedule_*`` or ``add_*`` ?
- ``SpiderManager.find_by_request`` or
``SpiderManager.search(request=request)`` ?

0 comments on commit 27ff010

Please sign in to comment.