[bitnami/grafana-tempo] support new deployment mode: scaling-monolithic #31028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rim99
force-pushed
the
support-scaling-monolithic
branch
3 times, most recently
from
567ad9c to
ce0e7fe
Compare
Signed-off-by: Zhang Xin <[email protected]>
rim99
force-pushed
the
support-scaling-monolithic
branch
from
51d6560 to
d8fc985
Compare
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
|
Thank you for this significant contribution, @rim99! The PR is currently in draft status. Please inform us when it's ready for testing and review. Thanks once more! |
carrodher
added
verify
|
Hi @jotamartos @migruiz4 , I've tested my changes with minikube locally. New statefulset works fine as a cluster. Regarding the VIB test, how to achieve 2 different sets of env for testing? Since it should test both cases:
|
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hello, just a reminder that this PR is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This change provides a new way of deployment:
scaling-monolithic.If toggle
.Values.tempo.deploymentMode, which is "microservices" by default, is set as "scalingMonolithic", single statefulset will be created. Each pod conatins all functions of components: distributor, ingester, query-frontend, querier, metrics-generator and compactor.Benefits
It helps to maintain a reasonable size of cluster handling small to medium volumes of incoming traces.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm