-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/seaweedfs] Fix OpenShift compatibility issues for S3 + Filer init containers #31192
base: main
Are you sure you want to change the base?
Conversation
Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines. Feel free to reach out if you have any questions or need assistance with the signing process. |
I just verified my GPG signature. Please review my pull request. |
The DCO verification is still failing, please take a look at https://github.com/bitnami/charts/pull/31192/checks?check_run_id=35042153282 to see how to fix the issue. |
* [bitnami/nginx] Release 18.3.2 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Martin Weise <[email protected]>
Great, thank you for the hint on fixing the issue. I could successfully rebase the commits. Never did that before :-) please review my changes. |
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
It seems it's needed to rebase from |
Description of the change
The
_helpers.tpl
did not allow for inclusions ofresources
(e.g. could not be overriden), so a change of the file is necessary to let the init containers of S3 + Filer pods be run on OpenShift clusters.Benefits
Init containers of S3 and Filer pods now run on OpenShift clusters.
Possible drawbacks
(none)
Applicable issues
(none)
Additional information
(none)
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm