Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/seaweedfs] Fix OpenShift compatibility issues for S3 + Filer init containers #31192

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MartinWeise
Copy link

Description of the change

The _helpers.tpl did not allow for inclusions of resources (e.g. could not be overriden), so a change of the file is necessary to let the init containers of S3 + Filer pods be run on OpenShift clusters.

Benefits

Init containers of S3 and Filer pods now run on OpenShift clusters.

Possible drawbacks

(none)

Applicable issues

(none)

Additional information

(none)

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added seaweedfs triage Triage is needed labels Jan 1, 2025
@github-actions github-actions bot requested a review from javsalgar January 1, 2025 13:59
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

@MartinWeise
Copy link
Author

I just verified my GPG signature. Please review my pull request.

@carrodher
Copy link
Member

The DCO verification is still failing, please take a look at https://github.com/bitnami/charts/pull/31192/checks?check_run_id=35042153282 to see how to fix the issue.

bitnami-bot and others added 3 commits January 8, 2025 08:51
* [bitnami/nginx] Release 18.3.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
Signed-off-by: Martin Weise <[email protected]>
@MartinWeise
Copy link
Author

Great, thank you for the hint on fixing the issue. I could successfully rebase the commits. Never did that before :-) please review my changes.

Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher
Copy link
Member

It seems it's needed to rebase from main since there are some undesired changes affecting NGINX Helm chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seaweedfs triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants