Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/jaeger] migration job not using namespaceOverwrite #31216

Conversation

MarcoFuykschot
Copy link
Contributor

Date: Sa Jan 4 20:42 2028 +01:00

Fix for https://github.com/bitnami/charts/issues/31207

Signed-off-by: Marco Fuykschot <[email protected]>

Description of the change

namespace of the migration-job is now using the include common.names.namespace

Benefits

namespaceOverride is consistent again

Checklist

@github-actions github-actions bot added jaeger triage Triage is needed labels Jan 4, 2025
@github-actions github-actions bot requested a review from carrodher January 4, 2025 19:53
@MarcoFuykschot MarcoFuykschot force-pushed the (fix)-migration-job-not-using-namespaceOverwrite-31207 branch 2 times, most recently from 1010315 to 712ba90 Compare January 4, 2025 19:58
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 4, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 4, 2025
@github-actions github-actions bot removed the request for review from carrodher January 4, 2025 23:08
@github-actions github-actions bot requested a review from jotamartos January 4, 2025 23:08
@MarcoFuykschot MarcoFuykschot changed the title [bitnami/jaeger] (fix) migration job not using namespaceOverwrite [bitnami/jaeger] migration job not using namespaceOverwrite Jan 6, 2025
@carrodher
Copy link
Member

Hi @MarcoFuykschot , thanks for your contribution, could you please rebase from main and bump the chart version again? There was a new version since when this PR was created

MarcoFuykschot and others added 2 commits January 13, 2025 20:59
Signed-off-by: Marco Fuykschot <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@MarcoFuykschot MarcoFuykschot force-pushed the (fix)-migration-job-not-using-namespaceOverwrite-31207 branch from 2f51b99 to 779d4e2 Compare January 13, 2025 20:01
@MarcoFuykschot
Copy link
Contributor Author

Done

Signed-off-by: Bitnami Containers <[email protected]>
jotamartos
jotamartos previously approved these changes Jan 14, 2025
Copy link
Contributor

@jotamartos jotamartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@jotamartos jotamartos enabled auto-merge (squash) January 14, 2025 11:44
Signed-off-by: Bitnami Containers <[email protected]>
@jotamartos
Copy link
Contributor

Hi @MarcoFuykschot,

Tests are returning 500 error messages when trying to connect to the test platform. Could you please update your branch with the latest changes in our repo? I'll take a look at the test results after that and merge the changes once they succeed.

@jotamartos
Copy link
Contributor

jotamartos commented Jan 14, 2025

Hi @MarcoFuykschot,

The issue may be related to the branch's name you used when pushing the changes. Apart from updating it, can you rename the branch removing the parenthesis (and recreate the PR if necessary)? I can see other jobs succeeded in our pipeline but this one continues failing.

auto-merge was automatically disabled January 16, 2025 19:57

Pull request was closed

@MarcoFuykschot MarcoFuykschot deleted the (fix)-migration-job-not-using-namespaceOverwrite-31207 branch January 16, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jaeger solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants