Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/jaeger] Migration job not using namespace overwrite 31207 #31405

Conversation

MarcoFuykschot
Copy link
Contributor

@MarcoFuykschot MarcoFuykschot commented Jan 16, 2025

Date: Sa Jan 4 20:42 2028 +01:00

Signed-off-by: Marco Fuykschot marcof@titaniumit.nl

Description of the change
namespace of the migration-job is now using the include common.names.namespace

Benefits
namespaceOverride is consistent again

Checklist

See other pr (rename of branch only)

Sorry, something went wrong.

MarcoFuykschot and others added 4 commits January 13, 2025 20:59
Signed-off-by: Marco Fuykschot <marcof@titaniumit.nl>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@github-actions github-actions bot added jaeger triage Triage is needed labels Jan 16, 2025
@github-actions github-actions bot requested a review from carrodher January 16, 2025 20:00
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 17, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 17, 2025
@github-actions github-actions bot removed the request for review from carrodher January 17, 2025 09:57
@github-actions github-actions bot requested a review from fmulero January 17, 2025 09:57
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @MarcoFuykschot for your contribution!

LGTM

@fmulero fmulero merged commit 2e7a486 into bitnami:main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jaeger solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migration job not using namespaceOverwrite
4 participants