Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] IpFamilies and IpFamilyPolicy configurables #31456

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

Yhasmina
Copy link

@Yhasmina Yhasmina commented Jan 17, 2025

Description of the change

Add the ability to configure the ipFamilyPolicy and ipFamilies in services. This is something that is needed in some environments where exists dual stack but we want to prefer just ipv6 ips, for example.

Benefits

It's possible to modify the ipFamilies and ipFamilyPolicy of all of the services of kafka deployment.

Additional information

By default the values are:

global:
  ipFamily:
  - IPv4
  ipFamilyPolicy: SingleStack

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added kafka triage Triage is needed labels Jan 17, 2025
@github-actions github-actions bot requested a review from carrodher January 17, 2025 13:03
@carrodher
Copy link
Member

Thank you for initiating this pull request. We appreciate your effort. This is just a friendly reminder that signing your commits is important. Your signature certifies that you either authored the patch or have the necessary rights to contribute to the changes. You can find detailed information on how to do this in the “Sign your work” section of our contributing guidelines.

Feel free to reach out if you have any questions or need assistance with the signing process.

bitnami-bot and others added 8 commits January 20, 2025 08:21
* [bitnami/mongodb-sharded] Release 9.1.1 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
* [bitnami/multus-cni] Release 2.2.1 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
…e via ruler.ruleFile parameter (bitnami#31377)

Signed-off-by: Yasmina Menendez <[email protected]>
* [bitnami/grafana-operator] Release 4.9.2 updating components versions

Signed-off-by: Bitnami Containers <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Bitnami Containers <[email protected]>

* Update CRDs automatically

Signed-off-by: Bitnami Containers <[email protected]>

---------

Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
@Yhasmina Yhasmina force-pushed the feature/yhasmina-allow-configure-ipFamily-services branch from 5c17158 to 073f623 Compare January 20, 2025 07:21
@carrodher
Copy link
Member

For @bitnami-bot to update the branch with the README, CHANGELOG, and CRDs, permission is needed for https://github.com/AllotSecure/bitnami-charts. Could you please grant the required access by inviting @bitnami-bot as a collaborator in the fork? Thanks!

Signed-off-by: Yasmina Menendez <[email protected]>
@Yhasmina
Copy link
Author

Yhasmina commented Jan 23, 2025

@carrodher I've added @bitnami-bot as a contributor with write permissions https://github.com/AllotSecure/bitnami-charts/invitations

Signed-off-by: Bitnami Containers <[email protected]>
@carrodher
Copy link
Member

Thanks, @bitnami-bot was able to update the branch, see 8dfa101.

It seems there are some conflicts that you need to solve before going ahead. Could you please rebase from main and solve the conflicts?

Yasmina Menendez and others added 9 commits January 27, 2025 10:23
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Yasmina Menendez <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
…github.com:AllotSecure/bitnami-charts into feature/yhasmina-allow-configure-ipFamily-services
Signed-off-by: Bitnami Containers <[email protected]>
@Yhasmina
Copy link
Author

@carrodher Conflicts solved. thanks

@carrodher
Copy link
Member

Unfortunately there are still some conflicts, see
Screenshot 2025-01-29 at 08 48 21

Yhasmina and others added 2 commits January 29, 2025 09:47
@Yhasmina
Copy link
Author

Sorry @carrodher , i don't understand why now is failing the [CI/CD] CI Pipeline / Get modified charts (pull_request_target) step, because i dind't change anything related to that in these days. I've added the new version of the chart in Chart.yaml file and also in the changelog.md. What else is needed?

Thanks

@carrodher
Copy link
Member

carrodher commented Jan 29, 2025

The error is

Error: Detected changes in charts without version bump in Chart.yaml. Charts changed: 1. Version bumps detected: 0

If there was a new release (#31624) and you rebased the changes from main, you will need to bump the chart version again, otherwise, it will use the one already in main.

Taking a look at the modified files (https://github.com/bitnami/charts/pull/31456/files), there are no changes in the Chart.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kafka triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants