Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] Fix Helm Template Error For Storegateway and HPA #31486

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

ryanmac8
Copy link
Contributor

@ryanmac8 ryanmac8 commented Jan 20, 2025

Description of the change

Fixes bug in helm chart template. When using Thanos Storegateway and HPA, an error appears due. This PR corrects the template.
Error message
Error: template: thanos/templates/storegateway/hpa-sharded.yaml:19:30: executing "thanos/templates/storegateway/hpa-sharded.yaml" at <$shards>: wrong type for value; expected int; got int64

Use --debug flag to render out invalid YAML`

Benefits

No more template errors :)

Possible drawbacks

None

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos triage Triage is needed labels Jan 20, 2025
@github-actions github-actions bot requested a review from javsalgar January 20, 2025 22:51
@ryanmac8 ryanmac8 changed the title bitnami/thanos Fix Helm Template Error For Storegateway and HPA [bitnami/thanos] Fix Helm Template Error For Storegateway and HPA Jan 20, 2025
Signed-off-by: Ryan Macdonald <[email protected]>
Signed-off-by: Ryan Macdonald <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 21, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 21, 2025
@github-actions github-actions bot removed the request for review from javsalgar January 21, 2025 08:06
@github-actions github-actions bot requested a review from fmulero January 21, 2025 08:06
Signed-off-by: Bitnami Containers <[email protected]>
@alvneiayu alvneiayu merged commit 9e323ab into bitnami:main Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thanos >= 10.8.5 template broken (on flux helm-controller?)
6 participants