Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/thanos] Remove quotes from --rule-file arg #31649

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

migruiz4
Copy link
Member

Description of the change

Remove the quotes from the --rule-file arg.

The quotes were accidentally added at #31377.

Users are reporting the feature not working since the change.

Benefits

Reverts quotes change while keeping the feature added.

Possible drawbacks

None known.

Applicable issues

Additional information

The change is quite simple, I tested it using the following command:

$ helm install thanos bitnami/thanos --set ruler.enabled=true --set ruler.existingConfigmap=a --set objstoreConfig=b --set "ruler.alertmanagers[0]=c" --dry-run | grep rule-file
            - --rule-file=/conf/rules/*.yml
$ helm install thanos oci://registry-1.docker.io/bitnamicharts/thanos --set ruler.enabled=true --set ruler.existingConfigmap=a --set objstoreConfig=b --set "ruler.alertmanagers[0]=c" --dry-run | grep rule-file
            - --rule-file="/conf/rules/*.yml"

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added thanos verify Execute verification workflow for these changes bitnami labels Jan 29, 2025
@github-actions github-actions bot requested a review from gongomgra January 29, 2025 08:33
Signed-off-by: Bitnami Containers <[email protected]>
gongomgra
gongomgra previously approved these changes Jan 29, 2025
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami thanos verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/thanos] Ruler configmap not loading since chart 15.10.0
3 participants