-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/redis] Handle SIGTERM in kubectl-shared
container
#32085
base: main
Are you sure you want to change the base?
[bitnami/redis] Handle SIGTERM in kubectl-shared
container
#32085
Conversation
Thanks for your contribution! Please submit changes to multiple charts in separate PRs to facilitate automated testing and merge of pull requests. |
Thanks @carrodher . I've removed the |
d3dd475
to
a327f3c
Compare
Unfortunately, there is still one more thing... Your fork doesn't allow @bitnami-bot to access it as a maintainer, which is required for the GitHub Action in charge of automatically updating the README, CHANGELOG, etc to succeed.
Could you please check this? |
@carrodher I've granted |
55d2c6f
to
461e8ab
Compare
…tl-shared` container runs a script with an infinite `while+sleep` loop. This script does not handle SIGTERM and causes the pod to hang upon termination until the termination grace period elapses. This change introduces a `preStop` hack to create a `terminate` file, which is used as a singal to the script that it should exit the infinite loop. Signed-off-by: Kevin Pullin <[email protected]>
90aacb8
to
28eee5e
Compare
Signed-off-by: Bitnami Containers <[email protected]>
kubectl-shared
containerkubectl-shared
container
Description of the change
When Redis Sentinel has the master service option enabled, the
kubectl-shared
container runs a script with an infinitewhile+sleep
loop.This script currently does not handle SIGTERM and causes the pod to hang upon termination until the
terminationGracePeriodSeconds
timeout elapses.This change introduces a
preStop
hack to create aterminate
file, which is used as a signal to the script that it should exit the infinite loop.Possible drawbacks
No known drawbacks
Applicable issues
N/A
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.