[bitnami/thanos] feature: allow configuring labels fir query ingress #32202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! As in the other case, your fork doesn't allow @bitnami-bot to access it as a maintainer, which is required for the GitHub Actions to succeed. Could you please check this? |
|
Thanks for your quick response, @carrodher! We have now added @bitnami-bot to the project with the maintainer role. Is there something else we need to do to re-launch the github-actions involved in the PR approval? |
carrodher
added
verify
juan131
requested changes
Mar 3, 2025
Comment on lines
12
to
15
| {{- if or .Values.query.ingress.labels .Values.commonLabels }} | ||
| {{- $labels := include "common.tplvalues.merge" ( dict "values" ( list .Values.query.ingress.labels .Values.commonLabels ) "context" . ) }} | ||
| labels: {{- include "common.tplvalues.render" ( dict "value" $labels "context" $) | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Labels should be set regardless they're .Values.query.ingress.labels OR .Values.commonLabels are set:
Suggested change
| {{- if or .Values.query.ingress.labels .Values.commonLabels }} | |
| {{- $labels := include "common.tplvalues.merge" ( dict "values" ( list .Values.query.ingress.labels .Values.commonLabels ) "context" . ) }} | |
| labels: {{- include "common.tplvalues.render" ( dict "value" $labels "context" $) | nindent 4 }} | |
| {{- end }} | |
| {{- $labels := include "common.tplvalues.merge" ( dict "values" ( list .Values.query.ingress.labels .Values.commonLabels ) "context" . ) }} | |
| labels: {{- include "common.labels.standard" ( dict "customLabels" $labels "context" $ ) | nindent 4 }} | |
| app.kubernetes.io/component: query |
There was a problem hiding this comment.
Thanks, you are right.
I've applied the proposed changes
bitnami#31607) * [bitnami/elasticsearch] fix: 🐛 Mount emptyDir in /bitnami/elasticsearch to allow init scripts Signed-off-by: leoarry <[email protected]> --------- Signed-off-by: leoarry <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Carlos Rodríguez Hernández <[email protected]> Co-authored-by: leoarry <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Carlos Rodríguez Hernández <[email protected]> Signed-off-by: Angel Abella <[email protected]>
* [bitnami/concourse] Release 5.1.15 updating components versions Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Angel Abella <[email protected]>
Signed-off-by: Angel Abella <[email protected]>
…ress.labels Signed-off-by: Angel Abella <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Angel Abella <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Angel Abella <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Angel Abella <[email protected]>
viyullas
force-pushed
the
feature/thanos-query-ingress-allow-labels
branch
from
14261b4 to
1c270fd
Compare
…sticsear… (bitnami#31607)" This reverts commit 59d7edd.
This reverts commit 89bbbae.
…uery.ingress.labels" This reverts commit 1efc025.
…ting .Values.query.ingress.labels Signed-off-by: Angel Abella <[email protected]>
|
I've closed this PR and started again on #32240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting labels for the query ingress just as annotations are allowed
Description of the change
Add the labels on the ingress template along with the common labels already present
Benefits
Now you can set labels on the query ingress if you need
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm