Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output env var to step.yml #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DamienBitrise
Copy link

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

To help the customer understand there are env var outputs

Changes

  • Add Env Var output

Investigation details

This is a hidden env var created by the step that Fastlane uses (It is used here)[https://github.com/fastlane/fastlane/blob/master/sigh/lib/sigh/options.rb#L65]

Decisions

Helping customers know what is going on

Copy link
Contributor

@tothszabi tothszabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have an ongoing discussion about this so I will temporarily block this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants