-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement crevice traits #164
Conversation
*except BVec*
Cargo.toml
Outdated
|
||
[dependencies] | ||
bytemuck = { version = "1.5", optional = true, default-features = false } | ||
crevice = { version = "0.6", optional = true, path = "../crevice" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to specify the crates.io version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK although I don't know what crevice is doing behind the scenes :)
|
||
[dependencies] | ||
bytemuck = { version = "1.5", optional = true, default-features = false } | ||
crevice = { version = "0.6", optional = true, git = "https://github.com/mtsr/crevice.git", branch = "develop" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't want to merge until this can use crates.io, I assume they need to make a new release or something?
Hi, I'm the author of Crevice, I just found this while preparing a different PR! I think that having math libraries depend on Crevice is tricky because of how domain-specific Crevice is. I have been working on two possible solutions to this problem, though:
If Crevice ends up manually supporting math libraries, it is likely that glam and cgmath will stay up to date, as they are the libraries that I use. It should be really easy for folks to PR upgrades to Crevice. I would prefer that Crevice have to semver churn a little bit than make every math library do it for the sake of Crevice. |
Going to close this as it's looking abandoned. |
This implements crevice::AsStd140 for relevant types except
BVec
.I wanted to check if something like this would be alright, before the remaining work:
BVec
AsStd430
trait