Add checked_* elementwise arithmetic operations for {I,U}Vec{2,3,4} #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitshifter
requested changes
Jan 28, 2025
| @@ -735,6 +735,43 @@ macro_rules! impl_vec2_signed_integer_tests { | |||
| assert_eq!((-$vec3::ONE).signum(), -$vec3::ONE); | |||
| }); | |||
|
|
|||
| glam_test!(test_checked_add, { | |||
| assert_eq!($vec3::MAX.checked_add($vec3::ONE), None); | |||
There was a problem hiding this comment.
these should be using $vec2 (the existing test_signum code above looks wrong)
| @@ -2161,7 +2240,7 @@ mod i8vec4 { | |||
| ); | |||
| }); | |||
|
|
|||
| glam_test!(test_wrapping_sub, { | |||
| glam_test!(test_wrapping_m, { | |||
There was a problem hiding this comment.
This looks like an unintended change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For integer vectors, it's often useful to check if an operation would overflow. This helps with writing more robust code without having to do checks with
ifstatements. Since we already havewrapping_andsaturating_from Rust standard library, I figured havingchecked_would be welcome as well.The test code is sadly very repetitive, as it's not generated from a template. Hopefully I got it all copy-pasted correctly!