checkForUpdateMode parameter added to start function

bitstadium · Aug 7, 2017 · 528aec0 · 528aec0
1 parent c8a0d1d
commit 528aec0
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/android/HockeyApp.java b/src/android/HockeyApp.java
@@ -45,6 +45,7 @@ public class HockeyApp extends CordovaPlugin {
     public static final long XWALK_SCREENSHOT_WAIT_MS = 5000;
     public static final String XWALK_SCREENSHOT_CAPTURE_MSG = "captureXWalkBitmap";
     public static final String XWALK_SCREENSHOT_BITMAP_MSG = "onGotXWalkBitmap";
+    private static final int CHECK_UPDATE_ON_STARTUP = 0;
 
     public static boolean initialized = false;
     public static String appId;
@@ -103,10 +104,14 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
             boolean autoSend = args.optBoolean(3);
             boolean ignoreDefaultHandler = args.optBoolean(4, false);
             boolean shouldCreateNewFeedbackThread = args.optBoolean(5, false);
-
             FeedbackManager.register(cordova.getActivity(), appId, shouldCreateNewFeedbackThread ? new SingleThreadFeedbackManagerListener() : null);
             this.crashListener = new ConfiguredCrashManagerListener(autoSend, ignoreDefaultHandler);
 
+            final int checkForUpdateMode = args.optInt(6, CHECK_UPDATE_ON_STARTUP);
+            if (checkForUpdateMode == CHECK_UPDATE_ON_STARTUP) {
+                UpdateManager.register(cordova.getActivity(), appId);
+            }
+
             MetricsManager.register(cordova.getActivity(), cordova.getActivity().getApplication(), appId);
             CrashManager.register(cordova.getActivity(), appId, this.crashListener);
 

diff --git a/src/ios/HockeyApp.m b/src/ios/HockeyApp.m
@@ -26,6 +26,8 @@ - (void) start:(CDVInvokedUrlCommand*)command
         NSString* token = [arguments objectAtIndex:0];
         NSString* autoSend = [arguments objectAtIndex:3];
         NSString* createNewFeedbackThread = [arguments objectAtIndex:5];
+        NSString* checkForUpdateModeString = [arguments objectAtIndex:6];
+        NSInteger checkForUpdateMode = [checkForUpdateModeString intValue];
         // no-op this for now. Appears to do nothing on ios side?
         // NSString* ignoreDefaultHandler = [arguments objectAtIndex:4];
 
@@ -40,6 +42,7 @@ - (void) start:(CDVInvokedUrlCommand*)command
 
         [[BITHockeyManager sharedHockeyManager] configureWithIdentifier:token
                                                                delegate:self];
+        [[BITHockeyManager sharedHockeyManager] updateManager].updateSetting = checkForUpdateMode;
         [[BITHockeyManager sharedHockeyManager] startManager];
 
         // Set authentication mode prior to verifying the user

diff --git a/www/hockeyapp.js b/www/hockeyapp.js
@@ -1,11 +1,12 @@
 var exec = require('cordova/exec');
 
 var hockeyapp = {
-    start: function(success, failure, appId, autoSend, ignoreDefaultHandler, createNewFeedbackThread, loginMode, appSecret) {
+start: function(success, failure, appId, autoSend, checkForUpdateMode, ignoreDefaultHandler, createNewFeedbackThread, loginMode, appSecret) {
         autoSend = (autoSend === true || autoSend === "true");
         ignoreDefaultHandler = (ignoreDefaultHandler === true || ignoreDefaultHandler === "true");
         loginMode = loginMode || hockeyapp.loginMode.ANONYMOUS;
         appSecret = appSecret || '';
+        checkForUpdateMode = checkForUpdateMode || hockeyapp.checkForUpdateMode.CHECK_ON_STARTUP;
         createNewFeedbackThread = (createNewFeedbackThread === true || createNewFeedbackThread === "true");
 
         // Requesting loginMode.EMAIL_ONLY without an appSecret is not permitted
@@ -16,7 +17,7 @@ var hockeyapp = {
             return;
         }
 
-        exec(success, failure, "HockeyApp", "start", [appId, loginMode, appSecret, autoSend, ignoreDefaultHandler,  createNewFeedbackThread]);
+        exec(success, failure, "HockeyApp", "start", [appId, loginMode, appSecret, autoSend, ignoreDefaultHandler,  createNewFeedbackThread, checkForUpdateMode]);
     },
     setUserEmail: function (success, failure, userEmail) {
       exec(success, failure, "HockeyApp", "setUserEmail", [userEmail]);
@@ -53,6 +54,11 @@ var hockeyapp = {
         EMAIL_ONLY: 1,
         EMAIL_PASSWORD: 2,
         VALIDATE: 3
+    },
+
+    checkForUpdateMode: {
+        CHECK_ON_STARTUP: 0,
+        CHECK_MANUALLY: 2
     }
 };