-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all instances using transceivers to one TX domain (+whole bunch of bug fixes) #716
Conversation
It had a logic error that meant the test could only indicate failure when all channels failed.
cf56e84
to
e5a48e1
Compare
Is not necessary anymore after fixing the handshake
e5a48e1
to
2393ad0
Compare
2393ad0
to
5d53bee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed the only 2 comments I had with Martijn, who quickly fixed it.
Imo all changes make sense are the commit history clearly shows the process. I also know that the transceivers are really complex, and I don't have enough transceiver-knowledge to spot any errors in the current code.
If you found any potential issues in the transceiver code now, or other things you'd like to fix in the future, make issues now that they are fresh in your heads.
Thanks :). Virtually all code was written by @leonschoorl, I just made the PR. It also has my seal of approval.
We haven't found anything we didn't fix. |
In #688 we modified the transceiver logic to operate on a single TX domain (but multiple RX domains). To keep the changes contained, we still exported multiple clocks still (though just as a
repeat
). This PR cleans this up and removes all superfluous synchronization. During this process we discovered a number of bugs:txReady
(both onInput
andOutput
). This caused confusion, that lead to the input'stxReady
to be looped back to theOutput
. This was clearly incorrect:Output.txReady
should clearly depend on whether a neighbor says it is ready to receive data!Fixes #696
TODO