Add numeric score to the result row, as bitSortable does not support …

…sorting by an object/object-ket (#11483) Co-authored-by: Daniel James Smith <[email protected]>
bitwarden · Oct 10, 2024 · 14d71e7 · 14d71e7
1 parent 16f36a1
commit 14d71e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html
@@ -39,7 +39,7 @@
             <th bitCell bitSortable="organizationId" *ngIf="!isAdminConsoleActive">
               {{ "owner" | i18n }}
             </th>
-            <th bitCell class="tw-text-right" bitSortable="reportValue" default>
+            <th bitCell class="tw-text-right" bitSortable="score" default>
               {{ "weakness" | i18n }}
             </th>
           </tr>

diff --git a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts
@@ -15,7 +15,7 @@ import { PasswordRepromptService } from "@bitwarden/vault";
 import { CipherReportComponent } from "./cipher-report.component";
 
 type ReportScore = { label: string; badgeVariant: BadgeVariant };
-type ReportResult = CipherView & { reportValue: ReportScore };
+type ReportResult = CipherView & { score: number; reportValue: ReportScore };
 
 @Component({
   selector: "app-weak-passwords-report",
@@ -100,7 +100,7 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
 
       if (result.score != null && result.score <= 2) {
         const scoreValue = this.scoreKey(result.score);
-        const row = { ...ciph, reportValue: scoreValue } as ReportResult;
+        const row = { ...ciph, score: result.score, reportValue: scoreValue } as ReportResult;
         this.weakPasswordCiphers.push(row);
       }
     });