[PM-15418] Remove bitItem and use plain bitLink button for opening ge…

…nerator history (#12208) * Remove bitItem and use plain bitLink button for opening generator history * Revert desktop back to use bitItem --------- Co-authored-by: Daniel James Smith <[email protected]>
bitwarden · Dec 2, 2024 · 19663d9 · 19663d9
1 parent 0ff48aa
commit 19663d9
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 23 deletions.
diff --git a/apps/desktop/src/app/tools/generator/credential-generator.component.html b/apps/desktop/src/app/tools/generator/credential-generator.component.html
@@ -6,6 +6,7 @@
       <button
         type="button"
         bitLink
+        linkType="primary"
         bit-item-content
         aria-haspopup="true"
         (click)="openHistoryDialog()"

diff --git a/apps/desktop/src/app/tools/generator/credential-generator.component.ts b/apps/desktop/src/app/tools/generator/credential-generator.component.ts
@@ -17,15 +17,7 @@ import {
   standalone: true,
   selector: "credential-generator",
   templateUrl: "credential-generator.component.html",
-  imports: [
-    DialogModule,
-    ButtonModule,
-    JslibModule,
-    GeneratorModule,
-    ItemModule,
-    ButtonModule,
-    LinkModule,
-  ],
+  imports: [DialogModule, ButtonModule, JslibModule, GeneratorModule, ItemModule, LinkModule],
 })
 export class CredentialGeneratorComponent {
   constructor(private dialogService: DialogService) {}

diff --git a/apps/web/src/app/tools/credential-generator/credential-generator.component.html b/apps/web/src/app/tools/credential-generator/credential-generator.component.html
@@ -2,16 +2,13 @@
 
 <bit-container>
   <tools-credential-generator />
-  <bit-item>
-    <button
-      type="button"
-      bitLink
-      bit-item-content
-      aria-haspopup="true"
-      (click)="openHistoryDialog()"
-    >
-      {{ "generatorHistory" | i18n }}
-      <i slot="end" class="bwi bwi-angle-right" aria-hidden="true"></i>
-    </button>
-  </bit-item>
+  <button
+    bitLink
+    type="button"
+    linkType="primary"
+    aria-haspopup="true"
+    (click)="openHistoryDialog()"
+  >
+    {{ "generatorHistory" | i18n }}
+  </button>
 </bit-container>
diff --git a/apps/web/src/app/tools/credential-generator/credential-generator.component.ts b/apps/web/src/app/tools/credential-generator/credential-generator.component.ts
@@ -1,6 +1,6 @@
 import { Component } from "@angular/core";
 
-import { ButtonModule, DialogService, ItemModule, LinkModule } from "@bitwarden/components";
+import { ButtonModule, DialogService, LinkModule } from "@bitwarden/components";
 import {
   CredentialGeneratorHistoryDialogComponent,
   GeneratorModule,
@@ -13,7 +13,7 @@ import { SharedModule } from "../../shared";
   standalone: true,
   selector: "credential-generator",
   templateUrl: "credential-generator.component.html",
-  imports: [SharedModule, HeaderModule, GeneratorModule, ItemModule, ButtonModule, LinkModule],
+  imports: [SharedModule, HeaderModule, GeneratorModule, ButtonModule, LinkModule],
 })
 export class CredentialGeneratorComponent {
   constructor(private dialogService: DialogService) {}