[PM-8831] Hide trashed items from new vault popup lists (#9633)

bitwarden · Jun 13, 2024 · 2333059 · 2333059
1 parent d266868
commit 2333059
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts b/apps/browser/src/vault/popup/services/vault-popup-list-filters.service.ts
@@ -2,10 +2,10 @@ import { Injectable } from "@angular/core";
 import { takeUntilDestroyed } from "@angular/core/rxjs-interop";
 import { FormBuilder } from "@angular/forms";
 import {
-  Observable,
   combineLatest,
   distinctUntilChanged,
   map,
+  Observable,
   startWith,
   switchMap,
   tap,
@@ -104,6 +104,11 @@ export class VaultPopupListFiltersService {
     map(
       (filters) => (ciphers: CipherView[]) =>
         ciphers.filter((cipher) => {
+          // Vault popup lists never shows deleted ciphers
+          if (cipher.isDeleted) {
+            return false;
+          }
+
           if (filters.cipherType !== null && cipher.type !== filters.cipherType) {
             return false;
           }