Revert "[PM-4290] Add pop out warning on import page (#6645)" (#6651)

* Revert "[PM-4290] Add pop out warning on import page (#6645)" This reverts commit 8dc81b6. * Change icon on `Import items` in browser-settings Replace the bwi-angle-right icon with the bwi-external-link and rotate it Box with arrow pointing to the top right indicates external linkg Box with arrow pointing to the top left indicates popout window --------- Co-authored-by: Daniel James Smith <[email protected]>
bitwarden · Oct 20, 2023 · 3e495ab · 3e495ab
1 parent c1494b8
commit 3e495ab
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 20 deletions.
diff --git a/apps/browser/src/popup/settings/settings.component.html b/apps/browser/src/popup/settings/settings.component.html
@@ -183,7 +183,10 @@ <h2 class="box-header">{{ "tools" | i18n }}</h2>
         (click)="import()"
       >
         <div class="row-main">{{ "importItems" | i18n }}</div>
-        <i class="bwi bwi-angle-right bwi-lg row-sub-icon" aria-hidden="true"></i>
+        <i
+          class="bwi bwi-external-link bwi-lg row-sub-icon bwi-rotate-270 bwi-fw"
+          aria-hidden="true"
+        ></i>
       </button>
       <button
         type="button"

diff --git a/apps/browser/src/popup/settings/settings.component.ts b/apps/browser/src/popup/settings/settings.component.ts
@@ -474,7 +474,10 @@ export class SettingsComponent implements OnInit {
   }
 
   async import() {
-    this.router.navigate(["/import"]);
+    await this.router.navigate(["/import"]);
+    if (await BrowserApi.isPopupOpen()) {
+      this.popupUtilsService.popOut(window);
+    }
   }
 
   export() {

diff --git a/apps/browser/src/tools/popup/settings/import/import-browser.component.html b/apps/browser/src/tools/popup/settings/import/import-browser.component.html
@@ -16,11 +16,9 @@ <h1 class="center">
   </div>
 </header>
 <div tabindex="-1" class="tw-p-4">
-  <tools-file-popout-callout />
   <tools-import
     (formDisabled)="this.disabled = $event"
     (formLoading)="this.loading = $event"
     (onSuccessfulImport)="this.onSuccessfulImport($event)"
-    [hideFileSelector]="this.hideFileSelector"
   ></tools-import>
 </div>
diff --git a/apps/browser/src/tools/popup/settings/import/import-browser.component.ts b/apps/browser/src/tools/popup/settings/import/import-browser.component.ts
@@ -1,14 +1,11 @@
 import { CommonModule } from "@angular/common";
-import { Component, OnInit } from "@angular/core";
+import { Component } from "@angular/core";
 import { Router, RouterLink } from "@angular/router";
 
 import { JslibModule } from "@bitwarden/angular/jslib.module";
 import { AsyncActionsModule, ButtonModule, DialogModule } from "@bitwarden/components";
 import { ImportComponent } from "@bitwarden/importer/ui";
 
-import { FilePopoutCalloutComponent } from "../../components/file-popout-callout.component";
-import { FilePopoutUtilsService } from "../../services/file-popout-utils.service";
-
 @Component({
   templateUrl: "import-browser.component.html",
   standalone: true,
@@ -20,20 +17,13 @@ import { FilePopoutUtilsService } from "../../services/file-popout-utils.service
     AsyncActionsModule,
     ButtonModule,
     ImportComponent,
-    FilePopoutCalloutComponent,
   ],
 })
-export class ImportBrowserComponent implements OnInit {
+export class ImportBrowserComponent {
   protected disabled = false;
   protected loading = false;
 
-  protected hideFileSelector = false;
-
-  constructor(private router: Router, private filePopoutUtilsService: FilePopoutUtilsService) {}
-
-  ngOnInit(): void {
-    this.hideFileSelector = this.filePopoutUtilsService.showFilePopoutMessage(window);
-  }
+  constructor(private router: Router) {}
 
   protected async onSuccessfulImport(organizationId: string): Promise<void> {
     this.router.navigate(["/tabs/settings"]);

diff --git a/libs/importer/src/components/import.component.html b/libs/importer/src/components/import.component.html
@@ -344,7 +344,7 @@
       and save the zip file.
     </ng-container>
   </bit-callout>
-  <bit-form-field *ngIf="!hideFileSelector">
+  <bit-form-field>
     <bit-label>{{ "selectImportFile" | i18n }}</bit-label>
     <div class="file-selector">
       <button bitButton type="button" buttonType="secondary" (click)="fileSelector.click()">

diff --git a/libs/importer/src/components/import.component.ts b/libs/importer/src/components/import.component.ts
@@ -120,8 +120,6 @@ export class ImportComponent implements OnInit, OnDestroy {
       });
   }
 
-  @Input() hideFileSelector: boolean;
-
   protected organization: Organization;
   protected destroy$ = new Subject<void>();
-Original file line number
+Diff line change
@@ Expand Up / @@ -120,8 +120,6 @@ export class ImportComponent implements OnInit, OnDestroy { @@
           });
       }
-      @Input() hideFileSelector: boolean;
       protected organization: Organization;
       protected destroy$ = new Subject<void>();
@@ Expand Down @@