Revert "added fromNullable to reduces repetitive logic"

This reverts commit ce5fc9c.
bitwarden · Oct 16, 2023 · 6270592 · 6270592
1 parent ce5fc9c
commit 6270592
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 15 deletions.
diff --git a/libs/common/src/models/export/fido2-credential.export.ts b/libs/common/src/models/export/fido2-credential.export.ts
@@ -37,17 +37,18 @@ export class Fido2CredentialExport {
   }
 
   static toDomain(req: Fido2CredentialExport, domain = new Fido2Credential()) {
-    domain.credentialId = EncString.fromNullable(req.credentialId);
-    domain.keyType = EncString.fromNullable(req.keyType);
-    domain.keyAlgorithm = EncString.fromNullable(req.keyAlgorithm);
-    domain.keyCurve = EncString.fromNullable(req.keyCurve);
-    domain.keyValue = EncString.fromNullable(req.keyValue);
-    domain.rpId = EncString.fromNullable(req.rpId);
-    domain.userHandle = EncString.fromNullable(req.userHandle);
-    domain.counter = EncString.fromNullable(req.counter);
-    domain.rpName = EncString.fromNullable(req.rpName);
-    domain.userDisplayName = EncString.fromNullable(req.userDisplayName);
-    domain.discoverable = EncString.fromNullable(req.discoverable);
+    domain.credentialId = req.credentialId != null ? new EncString(req.credentialId) : null;
+    domain.keyType = req.keyType != null ? new EncString(req.keyType) : null;
+    domain.keyAlgorithm = req.keyAlgorithm != null ? new EncString(req.keyAlgorithm) : null;
+    domain.keyCurve = req.keyCurve != null ? new EncString(req.keyCurve) : null;
+    domain.keyValue = req.keyValue != null ? new EncString(req.keyValue) : null;
+    domain.rpId = req.rpId != null ? new EncString(req.rpId) : null;
+    domain.userHandle = req.userHandle != null ? new EncString(req.userHandle) : null;
+    domain.counter = req.counter != null ? new EncString(req.counter) : null;
+    domain.rpName = req.rpName != null ? new EncString(req.rpName) : null;
+    domain.userDisplayName =
+      req.userDisplayName != null ? new EncString(req.userDisplayName) : null;
+    domain.discoverable = req.discoverable != null ? new EncString(req.discoverable) : null;
     domain.creationDate = req.creationDate;
     return domain;
   }

diff --git a/libs/common/src/platform/models/domain/enc-string.ts b/libs/common/src/platform/models/domain/enc-string.ts
@@ -43,10 +43,6 @@ export class EncString implements Encrypted {
     return this.encryptedString;
   }
 
-  static fromNullable(val: string | null) {
-    return val ? new EncString(val) : null;
-  }
-
   static fromJSON(obj: Jsonify<EncString>): EncString {
     if (obj == null) {
       return null;