Revert "[PM-13404] Weak Passwords Report - Sort by password weakness (#…

…12359)" (#13263) This reverts commit 582beaf.
bitwarden · Feb 5, 2025 · 9cbe295 · 9cbe295
1 parent f6eb08c
commit 9cbe295
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 31 deletions.
diff --git a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html
@@ -39,13 +39,7 @@
             <th bitCell bitSortable="organizationId" *ngIf="!isAdminConsoleActive">
               {{ "owner" | i18n }}
             </th>
-            <th
-              bitCell
-              class="tw-text-right"
-              bitSortable="score"
-              default
-              (sortChange)="onSortChange('score', $event)"
-            >
+            <th bitCell class="tw-text-right" bitSortable="score" default>
               {{ "weakness" | i18n }}
             </th>
           </tr>

diff --git a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts
@@ -59,7 +59,6 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
     this.weakPasswordCiphers = [];
     this.filterStatus = [0];
     this.findWeakPasswords(allCiphers);
-    this.weakPasswordCiphers = this.sortCiphers(this.weakPasswordCiphers, "score", false);
   }
 
   protected findWeakPasswords(ciphers: CipherView[]): void {
@@ -113,29 +112,6 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
     this.filterCiphersByOrg(this.weakPasswordCiphers);
   }
 
-  onSortChange(field: string, event: Event) {
-    const target = event.target as HTMLInputElement;
-    const ascending = target.checked;
-    this.weakPasswordCiphers = this.sortCiphers(this.weakPasswordCiphers, field, ascending);
-  }
-
-  protected sortCiphers(
-    ciphers: ReportResult[],
-    field: string,
-    ascending: boolean,
-  ): ReportResult[] {
-    return ciphers.sort((a, b) => {
-      const aValue = a[field as keyof ReportResult];
-      const bValue = b[field as keyof ReportResult];
-
-      if (aValue === bValue) {
-        return 0;
-      }
-      const comparison = aValue > bValue ? 1 : -1;
-      return ascending ? comparison : -comparison;
-    });
-  }
-
   protected canManageCipher(c: CipherView): boolean {
     // this will only ever be false from the org view;
     return true;