-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PM-13454] Get hostname for login uri (#11646)
* add uri to raw data * add uri * PM-13454 modify the hostnames to friendly names * PM-13454 removed commented code * add password health service * add spec. fix logic in password reuse * PM-13454 added member count and group by uris * PM-13454 removed moved files * PM-13454 fixed linting errors and failed unit tests * PM-13454 grouping member count * PM-13454 added unit test for totalGroupedMembersMap * PM-13454 removed the grouping - show a flatmap --------- Co-authored-by: jaasen-livefront <[email protected]>
- Loading branch information
1 parent
82d4fe4
commit ab3d760
Showing
9 changed files
with
273 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <bit-container> | ||
| <p>{{ "passwordsReportDesc" | i18n }}</p> | ||
| <div *ngIf="loading"> | ||
| <i | ||
| class="bwi bwi-spinner bwi-spin tw-text-muted" | ||
| title="{{ 'loading' | i18n }}" | ||
| aria-hidden="true" | ||
| ></i> | ||
| <span class="tw-sr-only">{{ "loading" | i18n }}</span> | ||
| </div> | ||
| <div class="tw-mt-4" *ngIf="!loading"> | ||
| <bit-table [dataSource]="dataSource"> | ||
| <ng-container header> | ||
| <tr bitRow> | ||
| <th bitCell bitSortable="hostURI">{{ "application" | i18n }}</th> | ||
| <th bitCell class="tw-text-right">{{ "weakness" | i18n }}</th> | ||
| <th bitCell class="tw-text-right">{{ "timesReused" | i18n }}</th> | ||
| <th bitCell class="tw-text-right">{{ "timesExposed" | i18n }}</th> | ||
| <th bitCell class="tw-text-right">{{ "totalMembers" | i18n }}</th> | ||
| </tr> | ||
| </ng-container> | ||
| <ng-template body let-rows$> | ||
| <tr bitRow *ngFor="let r of rows$ | async"> | ||
| <td bitCell> | ||
| <ng-container> | ||
| <span>{{ r.hostURI }}</span> | ||
| </ng-container> | ||
| </td> | ||
| <td bitCell class="tw-text-right"> | ||
| <span | ||
| bitBadge | ||
| *ngIf="passwordStrengthMap.has(r.id)" | ||
| [variant]="passwordStrengthMap.get(r.id)[1]" | ||
| > | ||
| {{ passwordStrengthMap.get(r.id)[0] | i18n }} | ||
| </span> | ||
| </td> | ||
| <td bitCell class="tw-text-right"> | ||
| <span bitBadge *ngIf="passwordUseMap.has(r.login.password)" variant="warning"> | ||
| {{ "reusedXTimes" | i18n: passwordUseMap.get(r.login.password) }} | ||
| </span> | ||
| </td> | ||
| <td bitCell class="tw-text-right"> | ||
| <span bitBadge *ngIf="exposedPasswordMap.has(r.id)" variant="warning"> | ||
| {{ "exposedXTimes" | i18n: exposedPasswordMap.get(r.id) }} | ||
| </span> | ||
| </td> | ||
| <td bitCell class="tw-text-right" data-testid="total-membership"> | ||
| {{ totalMembersMap.get(r.id) || 0 }} | ||
| </td> | ||
| </tr> | ||
| </ng-template> | ||
| </bit-table> | ||
| </div> | ||
| </bit-container> |
61 changes: 61 additions & 0 deletions
61
apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { ComponentFixture, TestBed } from "@angular/core/testing"; | ||
| import { ActivatedRoute, convertToParamMap } from "@angular/router"; | ||
| import { mock, MockProxy } from "jest-mock-extended"; | ||
| import { of } from "rxjs"; | ||
|
|
||
| // eslint-disable-next-line no-restricted-imports | ||
| import { PasswordHealthService } from "@bitwarden/bit-common/tools/reports/access-intelligence"; | ||
| import { AuditService } from "@bitwarden/common/abstractions/audit.service"; | ||
| import { OrganizationService } from "@bitwarden/common/admin-console/abstractions/organization/organization.service.abstraction"; | ||
| import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; | ||
| import { PasswordStrengthServiceAbstraction } from "@bitwarden/common/tools/password-strength"; | ||
| import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service"; | ||
| import { TableModule } from "@bitwarden/components"; | ||
|
|
||
| import { LooseComponentsModule } from "../../shared"; | ||
| import { PipesModule } from "../../vault/individual-vault/pipes/pipes.module"; | ||
|
|
||
| import { PasswordHealthMembersURIComponent } from "./password-health-members-uri.component"; | ||
|
|
||
| describe("PasswordHealthMembersUriComponent", () => { | ||
| let component: PasswordHealthMembersURIComponent; | ||
| let fixture: ComponentFixture<PasswordHealthMembersURIComponent>; | ||
| let cipherServiceMock: MockProxy<CipherService>; | ||
| const passwordHealthServiceMock = mock<PasswordHealthService>(); | ||
|
|
||
| const activeRouteParams = convertToParamMap({ organizationId: "orgId" }); | ||
|
|
||
| beforeEach(async () => { | ||
| cipherServiceMock = mock<CipherService>(); | ||
| await TestBed.configureTestingModule({ | ||
| imports: [PasswordHealthMembersURIComponent, PipesModule, TableModule, LooseComponentsModule], | ||
| providers: [ | ||
| { provide: CipherService, useValue: cipherServiceMock }, | ||
| { provide: I18nService, useValue: mock<I18nService>() }, | ||
| { provide: AuditService, useValue: mock<AuditService>() }, | ||
| { provide: OrganizationService, useValue: mock<OrganizationService>() }, | ||
| { | ||
| provide: PasswordStrengthServiceAbstraction, | ||
| useValue: mock<PasswordStrengthServiceAbstraction>(), | ||
| }, | ||
| { provide: PasswordHealthService, useValue: passwordHealthServiceMock }, | ||
| { | ||
| provide: ActivatedRoute, | ||
| useValue: { | ||
| paramMap: of(activeRouteParams), | ||
| url: of([]), | ||
| }, | ||
| }, | ||
| ], | ||
| }).compileComponents(); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| fixture = TestBed.createComponent(PasswordHealthMembersURIComponent); | ||
| component = fixture.componentInstance; | ||
| }); | ||
|
|
||
| it("should initialize component", () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
| }); |
108 changes: 108 additions & 0 deletions
108
apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| import { CommonModule } from "@angular/common"; | ||
| import { Component, DestroyRef, inject, OnInit } from "@angular/core"; | ||
| import { takeUntilDestroyed } from "@angular/core/rxjs-interop"; | ||
| import { ActivatedRoute } from "@angular/router"; | ||
| import { map } from "rxjs"; | ||
|
|
||
| import { JslibModule } from "@bitwarden/angular/jslib.module"; | ||
| // eslint-disable-next-line no-restricted-imports | ||
| import { PasswordHealthService } from "@bitwarden/bit-common/tools/reports/access-intelligence"; | ||
| import { AuditService } from "@bitwarden/common/abstractions/audit.service"; | ||
| import { OrganizationService } from "@bitwarden/common/admin-console/abstractions/organization/organization.service.abstraction"; | ||
| import { Organization } from "@bitwarden/common/admin-console/models/domain/organization"; | ||
| import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; | ||
| import { PasswordStrengthServiceAbstraction } from "@bitwarden/common/tools/password-strength"; | ||
| import { CipherService } from "@bitwarden/common/vault/abstractions/cipher.service"; | ||
| import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; | ||
| import { | ||
| BadgeModule, | ||
| BadgeVariant, | ||
| ContainerComponent, | ||
| TableDataSource, | ||
| TableModule, | ||
| } from "@bitwarden/components"; | ||
|
|
||
| // eslint-disable-next-line no-restricted-imports | ||
| import { HeaderModule } from "../../layouts/header/header.module"; | ||
| // eslint-disable-next-line no-restricted-imports | ||
| import { OrganizationBadgeModule } from "../../vault/individual-vault/organization-badge/organization-badge.module"; | ||
| // eslint-disable-next-line no-restricted-imports | ||
| import { PipesModule } from "../../vault/individual-vault/pipes/pipes.module"; | ||
|
|
||
| @Component({ | ||
| standalone: true, | ||
| selector: "tools-password-health-members-uri", | ||
| templateUrl: "password-health-members-uri.component.html", | ||
| imports: [ | ||
| BadgeModule, | ||
| OrganizationBadgeModule, | ||
| CommonModule, | ||
| ContainerComponent, | ||
| PipesModule, | ||
| JslibModule, | ||
| HeaderModule, | ||
| TableModule, | ||
| ], | ||
| providers: [PasswordHealthService], | ||
| }) | ||
| export class PasswordHealthMembersURIComponent implements OnInit { | ||
| passwordStrengthMap = new Map<string, [string, BadgeVariant]>(); | ||
|
|
||
| weakPasswordCiphers: CipherView[] = []; | ||
|
|
||
| passwordUseMap = new Map<string, number>(); | ||
|
|
||
| exposedPasswordMap = new Map<string, number>(); | ||
|
|
||
| totalMembersMap = new Map<string, number>(); | ||
|
|
||
| dataSource = new TableDataSource<CipherView>(); | ||
|
|
||
| reportCiphers: (CipherView & { hostURI: string })[] = []; | ||
| reportCipherURIs: string[] = []; | ||
|
|
||
| organization: Organization; | ||
|
|
||
| loading = true; | ||
|
|
||
| private destroyRef = inject(DestroyRef); | ||
|
|
||
| constructor( | ||
| protected cipherService: CipherService, | ||
| protected passwordStrengthService: PasswordStrengthServiceAbstraction, | ||
| protected organizationService: OrganizationService, | ||
| protected auditService: AuditService, | ||
| protected i18nService: I18nService, | ||
| protected activatedRoute: ActivatedRoute, | ||
| ) {} | ||
|
|
||
| ngOnInit() { | ||
| this.activatedRoute.paramMap | ||
| .pipe( | ||
| takeUntilDestroyed(this.destroyRef), | ||
| map(async (params) => { | ||
| const organizationId = params.get("organizationId"); | ||
| await this.setCiphers(organizationId); | ||
| }), | ||
| ) | ||
| .subscribe(); | ||
| } | ||
|
|
||
| async setCiphers(organizationId: string) { | ||
| const passwordHealthService = new PasswordHealthService( | ||
| this.passwordStrengthService, | ||
| this.auditService, | ||
| this.cipherService, | ||
| organizationId, | ||
| ); | ||
|
|
||
| await passwordHealthService.generateReport(); | ||
|
|
||
| this.dataSource.data = passwordHealthService.groupCiphersByLoginUri(); | ||
| this.exposedPasswordMap = passwordHealthService.exposedPasswordMap; | ||
| this.passwordStrengthMap = passwordHealthService.passwordStrengthMap; | ||
| this.passwordUseMap = passwordHealthService.passwordUseMap; | ||
| this.totalMembersMap = passwordHealthService.totalMembersMap; | ||
| this.loading = false; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,5 +64,16 @@ export const mockMemberCipherDetailsResponse: { data: any[] } = { | |
| "cbea34a8-bde4-46ad-9d19-b05001228xy4", | ||
| ], | ||
| }, | ||
| { | ||
| UserName: "Chris Finch Tester", | ||
| Email: "[email protected]", | ||
| UsesKeyConnector: true, | ||
| cipherIds: [ | ||
| "cbea34a8-bde4-46ad-9d19-b05001228ab2", | ||
| "cbea34a8-bde4-46ad-9d19-b05001228cd3", | ||
| "cbea34a8-bde4-46ad-9d19-b05001228xy4", | ||
| "cbea34a8-bde4-46ad-9d19-b05001228ab1", | ||
| ], | ||
| }, | ||
| ], | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters