[AC-2614] Member access test fix (#10969)

* Initial setup and modifications for member access report api implementation * Adding the permissions logic for getting the permissions text * fixing the test cases * Some refactoring on async calls * Comments on the model * Resolving the mock issue * messages * Localization of text * One more file to fix merge * Fixing test case localization lookup * Fixed permissions lookup (cherry picked from commit cdb4081)
bitwarden · Sep 10, 2024 · b6da700 · b6da700
1 parent 10ea8e9
commit b6da700
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/.../src/app/tools/reports/member-access-report/services/member-access-report.service.spec.ts b/.../src/app/tools/reports/member-access-report/services/member-access-report.service.spec.ts
@@ -10,13 +10,17 @@ describe("ImportService", () => {
   const mockOrganizationId = "mockOrgId" as OrganizationId;
   const reportApiService = mock<MemberAccessReportApiService>();
   let memberAccessReportService: MemberAccessReportService;
-  const i18nService = mock<I18nService>();
+  const i18nMock = mock<I18nService>({
+    t(key) {
+      return key;
+    },
+  });
 
   beforeEach(() => {
     reportApiService.getMemberAccessData.mockImplementation(() =>
       Promise.resolve(memberAccessReportsMock),
     );
-    memberAccessReportService = new MemberAccessReportService(reportApiService, i18nService);
+    memberAccessReportService = new MemberAccessReportService(reportApiService, i18nMock);
   });
 
   describe("generateMemberAccessReportView", () => {
@@ -92,16 +96,16 @@ describe("ImportService", () => {
           expect.objectContaining({
             email: "[email protected]",
             name: "Sarah Johnson",
-            twoStepLogin: "On",
-            accountRecovery: "On",
+            twoStepLogin: "memberAccessReportTwoFactorEnabledTrue",
+            accountRecovery: "memberAccessReportAuthenticationEnabledTrue",
             group: "Group 1",
             totalItems: "20",
           }),
           expect.objectContaining({
             email: "[email protected]",
             name: "James Lull",
-            twoStepLogin: "Off",
-            accountRecovery: "Off",
+            twoStepLogin: "memberAccessReportTwoFactorEnabledFalse",
+            accountRecovery: "memberAccessReportAuthenticationEnabledFalse",
             group: "Group 4",
             totalItems: "5",
           }),

diff --git a/...t-web/src/app/tools/reports/member-access-report/services/member-access-report.service.ts b/...t-web/src/app/tools/reports/member-access-report/services/member-access-report.service.ts
@@ -82,7 +82,7 @@ export class MemberAccessReportService {
             : this.i18nService.t("memberAccessReportNoCollection"),
           collectionPermission: detail.collectionId
             ? this.getPermissionText(detail)
-            : this.i18nService.t("memberAccessReportNoCollection"),
+            : this.i18nService.t("memberAccessReportNoCollectionPermission"),
           totalItems: detail.itemCount.toString(),
         };
       });