PM-8113 - Clean up used service method + TODO as I've confirmed it wo…

…rks for other flows.
bitwarden · Jan 24, 2025 · e6e3cf6 · e6e3cf6
1 parent 8506449
commit e6e3cf6
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts b/apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts
@@ -38,12 +38,7 @@ export class ExtensionTwoFactorAuthComponentService
     document.body.classList.remove("linux-webauthn");
   }
 
-  closeWindow(): void {
-    this.window.close();
-  }
-
   async handle2faSuccess(): Promise<void> {
-    // TODO: confirm that moving this from SSO flow only to general flow doesn't introduce any issues
     // Force sidebars (FF && Opera) to reload while exempting current window
     // because we are just going to close the current window if it is in a popout
     // or navigate forward if it is in the popup

diff --git a/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts b/libs/auth/src/angular/two-factor-auth/two-factor-auth-component.service.ts
@@ -29,11 +29,6 @@ export abstract class TwoFactorAuthComponentService {
    */
   abstract removePopupWidthExtension?(): void;
 
-  /**
-   * Optionally closes the window if the client requires it
-   */
-  abstract closeWindow?(): void;
-
   /**
    * We used to use the user's master key to encrypt their data. We deprecated that approach
    * and now use a user key. This method should be called if we detect that the user