Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9708] [Bootstrap] Convert remaining sr-only to tw-sr-only #10094

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jul 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9708

📔 Objective

We're in the process of removing bootstrap from our web vault. As part of this I've started to audit the areas that breaks in #8071.

We're still using sr-only in multiple places. This is a bootstrap utility class and needs to be migrated to tw-sr-only.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested review from a team as code owners July 12, 2024 13:26
@Hinton Hinton requested review from r-tome, Jingo88 and quexten July 12, 2024 13:26
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 30.17%. Comparing base (fb311bf) to head (b25ba86).

Files Patch % Lines
..._license/bit-web/src/app/auth/sso/sso.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10094      +/-   ##
==========================================
- Coverage   30.18%   30.17%   -0.01%     
==========================================
  Files        2587     2587              
  Lines       75738    75738              
  Branches    14189    14189              
==========================================
- Hits        22858    22851       -7     
- Misses      51108    51115       +7     
  Partials     1772     1772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jul 12, 2024

Logo
Checkmarx One – Scan Summary & Details3218a552-e05e-41ed-81c2-858d4ac2d555

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/reused-passwords-report.component.ts: 47 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/weak-passwords-report.component.ts: 22 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/reused-passwords-report.component.ts: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html: 95 Attack Vector

@Hinton Hinton enabled auto-merge (squash) July 12, 2024 13:52
djsmith85
djsmith85 previously approved these changes Jul 15, 2024
@Hinton Hinton merged commit d852a5f into main Jul 16, 2024
32 of 33 checks passed
@Hinton Hinton deleted the ps/convert-sr-only branch July 16, 2024 10:59
@Hinton Hinton changed the title [PM-97089] [Bootstrap] Convert remaining sr-only to tw-sr-only [PM-9708] [Bootstrap] Convert remaining sr-only to tw-sr-only Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants