-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-9708] [Bootstrap] Convert remaining sr-only to tw-sr-only #10094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10094 +/- ##
==========================================
- Coverage 30.18% 30.17% -0.01%
==========================================
Files 2587 2587
Lines 75738 75738
Branches 14189 14189
==========================================
- Hits 22858 22851 -7
- Misses 51108 51115 +7
Partials 1772 1772 ☔ View full report in Codecov by Sentry. |
New Issues
|
djsmith85
previously approved these changes
Jul 15, 2024
djsmith85
approved these changes
Jul 15, 2024
r-tome
approved these changes
Jul 15, 2024
quexten
approved these changes
Jul 15, 2024
cturnbull-bitwarden
approved these changes
Jul 15, 2024
LRNcardozoWDF
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-9708
📔 Objective
We're in the process of removing bootstrap from our web vault. As part of this I've started to audit the areas that breaks in #8071.
We're still using
sr-only
in multiple places. This is a bootstrap utility class and needs to be migrated totw-sr-only
.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes