Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9423] observable user encryptor #10271

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

audreyality
Copy link
Member

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-9423

๐Ÿ“” Objective

Lift user key encryptor into an observable provided at construction time.

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@audreyality audreyality requested a review from a team as a code owner July 25, 2024 18:26
@audreyality audreyality requested a review from MGibson1 July 25, 2024 18:34
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 31.67%. Comparing base (84ee01c) to head (aeb3b55).
Report is 5 commits behind head on main.

Files Patch % Lines
...ore/src/strategies/forwarder-generator-strategy.ts 60.00% 2 Missing โš ๏ธ
...ons/history/src/local-generator-history.service.ts 80.00% 0 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10271      +/-   ##
==========================================
- Coverage   31.67%   31.67%   -0.01%     
==========================================
  Files        2623     2623              
  Lines       79418    79421       +3     
  Branches    14974    14974              
==========================================
- Hits        25159    25153       -6     
- Misses      52305    52313       +8     
- Partials     1954     1955       +1     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

This comment was marked as spam.

djsmith85
djsmith85 previously approved these changes Jul 30, 2024
@audreyality audreyality removed the request for review from MGibson1 July 30, 2024 16:40
@audreyality audreyality added needs-qa Marks a PR as requiring QA approval and removed needs-qa Marks a PR as requiring QA approval labels Jul 30, 2024
@audreyality audreyality merged commit d26ea1b into main Aug 1, 2024
66 of 67 checks passed
@audreyality audreyality deleted the tools/pm-9423/observable-user-encryptor branch August 1, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants