Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-3530] browser extension view cache #10437

Merged
merged 49 commits into from
Aug 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
dbbf307
[PM-8589] persist dirty form data (wip)
willmartian Jun 9, 2024
c887bab
[PM-8589] serialize value comparsion in CL select components
willmartian Jun 9, 2024
96a71fc
[PM-8589] test implementation in send-add-edit and vault-popup-list-fโ€ฆ
willmartian Jun 9, 2024
8f9bb2d
[PM-8588] persist extension route history (wip)
willmartian Jun 9, 2024
64e6bab
temp: override feature flag
willmartian Jun 9, 2024
4185010
gate behind FeatureFlag.ExtensionRefresh
willmartian Jun 9, 2024
286f909
share single StateDefinition
willmartian Jun 9, 2024
0c25260
use large object storage; use global state provider with manual clearโ€ฆ
willmartian Jun 10, 2024
38a6c32
add new feature flag
willmartian Jun 19, 2024
9b4ac8f
wip
willmartian Jun 21, 2024
e432d28
wip; add tests for guard
willmartian Jun 25, 2024
6d4d97b
resolve merge conflict
willmartian Jun 25, 2024
1a6eb9f
add flag to service back method
willmartian Jun 25, 2024
13d3e40
wip
willmartian Jul 2, 2024
d88e7e8
add tests; fix bug
willmartian Jul 2, 2024
f274a02
rename
willmartian Jul 2, 2024
ff93cd0
resolve merge conflicts
willmartian Jul 2, 2024
b033a70
remove feature flag override
willmartian Jul 2, 2024
d6ef9c0
revert usage examples
willmartian Jul 2, 2024
6a0d99a
fix merge error
willmartian Jul 2, 2024
6a97de6
resolve merge conflicts
willmartian Jul 18, 2024
76b4c94
remove unecessary call to clear state
willmartian Jul 26, 2024
8d2aab9
fix account switch clear state after latest merge commit
willmartian Jul 26, 2024
e2a3863
save route history to URL param when building popout url
willmartian Jul 26, 2024
aded1e5
resolve merge conflicts
willmartian Jul 26, 2024
28431e2
cr: remove promise in subscribe; remove comment from test
willmartian Jul 26, 2024
c07b840
vicki cr changes
willmartian Jul 26, 2024
33f86d0
add back method test
willmartian Jul 26, 2024
2541915
fix popup utils tests
willmartian Jul 26, 2024
a732ef5
remove 'T' prefix from type names
willmartian Jul 31, 2024
0081a4e
Merge branch 'main' into ps/PM-3530/popup-view-persistence
willmartian Aug 2, 2024
30e3997
rename view cache service
willmartian Aug 2, 2024
9ad6259
rename files
willmartian Aug 3, 2024
88d235a
add default implementation to libs/angular
willmartian Aug 3, 2024
5a3337f
move & rename files
willmartian Aug 3, 2024
025e771
remove view cache references to split PR
willmartian Aug 7, 2024
6674b20
Revert "remove view cache references to split PR"
willmartian Aug 7, 2024
da7a7cf
merge in main and resolve conflicts
willmartian Aug 13, 2024
431d942
revert browser-popup-utils and pop-out component
willmartian Aug 13, 2024
afd12db
add to services module
willmartian Aug 20, 2024
1ff8b48
remove DS change
willmartian Aug 20, 2024
a557ec4
remove temp changes
willmartian Aug 20, 2024
a8e2af7
Merge branch 'main' into ps/PM-3530/view-cache
willmartian Aug 20, 2024
8ac50e4
update comment
willmartian Aug 21, 2024
811761b
add feature flag
willmartian Aug 22, 2024
86b05f8
split noop implementation and abstract class
willmartian Aug 22, 2024
556683a
add comments
willmartian Aug 22, 2024
1f22860
add to jslib services module
willmartian Aug 22, 2024
ff6e42a
add flag to update state
willmartian Aug 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[PM-8589] test implementation in send-add-edit and vault-popup-list-fโ€ฆ
โ€ฆilters
  • Loading branch information
willmartian committed Jun 9, 2024
commit 96a71fcf32b071e4529b92500d46f1802a21d88f
7 changes: 6 additions & 1 deletion apps/browser/src/tools/popup/send/send-add-edit.component.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { DatePipe, Location } from "@angular/common";
import { Component } from "@angular/core";
import { Component, inject } from "@angular/core";
import { FormBuilder } from "@angular/forms";
import { ActivatedRoute, Router } from "@angular/router";
import { first } from "rxjs/operators";
@@ -18,6 +18,7 @@ import { SendService } from "@bitwarden/common/tools/send/services/send.service.
import { DialogService } from "@bitwarden/components";

import BrowserPopupUtils from "../../../platform/popup/browser-popup-utils";
import { DirtyFormService } from "../../../platform/popup/services/dirty-form.service";
import { BrowserStateService } from "../../../platform/services/abstractions/browser-state.service";
import { FilePopoutUtilsService } from "../services/file-popout-utils.service";

@@ -27,6 +28,8 @@ import { FilePopoutUtilsService } from "../services/file-popout-utils.service";
})
// eslint-disable-next-line rxjs-angular/prefer-takeuntil
export class SendAddEditComponent extends BaseAddEditComponent {
protected dirtyFormService = inject(DirtyFormService);

// Options header
showOptions = false;
// File visibility
@@ -97,6 +100,8 @@ export class SendAddEditComponent extends BaseAddEditComponent {
await super.ngOnInit();
});

await this.dirtyFormService.register(this.formGroup, { key: "browser-send-add-edit" });

window.setTimeout(() => {
if (!this.editMode) {
document.getElementById("name").focus();
Original file line number Diff line number Diff line change
@@ -29,6 +29,8 @@ import { FolderView } from "@bitwarden/common/vault/models/view/folder.view";
import { ServiceUtils } from "@bitwarden/common/vault/service-utils";
import { ChipSelectOption } from "@bitwarden/components";

import { DirtyFormService } from "../../../platform/popup/services/dirty-form.service";

/** All available cipher filters */
export type PopupListFilter = {
organization: Organization | null;
@@ -88,7 +90,10 @@ export class VaultPopupListFiltersService {
private i18nService: I18nService,
private collectionService: CollectionService,
private formBuilder: FormBuilder,
private dirtyFormService: DirtyFormService,
) {
void this.dirtyFormService.register(this.filterForm, { key: "vault-list-filters-form" });

this.filterForm.controls.organization.valueChanges
.pipe(takeUntilDestroyed())
.subscribe(this.validateOrganizationChange.bind(this));
Loading