[PM-10026] [Defect] Zip code is not being enforced when subscribing in Password Manager

[cyprain-okeke]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10026

📔 Objective

In main the zip code field is marked as (Required), but you can still create a subscription without entering one. In production you can also subscribe without having to enter a zip code. It is not this way when upgrading your organization in Admin Console though. I’m not certain what the expected behavior in production should be at this point, if it’s always been this way or was just introduced recently, but it seems like it should behave like the other required fields. Because of this I’m not sure if I marked the priority correct or if this is not a big issue.

📸 Screenshots

Screen.Recording.2024-08-08.at.17.14.58.mov

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – e368b16a-2f19-48ca-82d3-7d34a79f41ff

No New Or Fixed Issues Found

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 32.28%. Comparing base (bca619d) to head (def835e).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...eb/src/app/billing/individual/premium.component.ts	0.00%	4 Missing ⚠️
...ling/organizations/organization-plans.component.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10446      +/-   ##
==========================================
- Coverage   32.28%   32.28%   -0.01%     
==========================================
  Files        2650     2650              
  Lines       80752    80754       +2     
  Branches    15221    15223       +2     
==========================================
  Hits        26071    26071              
- Misses      52682    52684       +2     
  Partials     1999     1999              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.