Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-6564] migrate auth toasts to CL toastService #10665

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-6564

📔 Objective

This PR migrates all auth toasts to the CL toastService

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 21, 2024

Logo
Checkmarx One – Scan Summary & Detailsfb54678b-0caa-467b-aaa4-b1bece54b748

Fixed Issues

Severity Issue Source File / Package
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_DOM_Open_Redirect /apps/web/src/connectors/common.ts: 2
LOW Client_JQuery_Deprecated_Symbols /libs/importer/src/services/import.service.ts: 455

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 15.72052% with 193 lines in your changes missing coverage. Please review.

Project coverage is 32.84%. Comparing base (3fc1b57) to head (0d16be3).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
...ngs/emergency-access/emergency-access.component.ts 10.00% 9 Missing ⚠️
libs/angular/src/auth/components/lock.component.ts 0.00% 8 Missing ⚠️
...uth/components/login-via-auth-request.component.ts 0.00% 7 Missing ⚠️
.../angular/src/auth/components/register.component.ts 0.00% 7 Missing ⚠️
...r/src/auth/components/change-password.component.ts 0.00% 6 Missing ⚠️
...r/src/auth/components/remove-password.component.ts 0.00% 6 Missing ⚠️
.../auth/popup/settings/account-security.component.ts 0.00% 5 Missing ⚠️
...desktop/src/auth/accessibility-cookie.component.ts 0.00% 5 Missing ⚠️
...desktop/src/auth/login/login-approval.component.ts 0.00% 5 Missing ⚠️
...src/app/auth/settings/change-password.component.ts 16.66% 5 Missing ⚠️
... and 58 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10665      +/-   ##
==========================================
- Coverage   32.86%   32.84%   -0.03%     
==========================================
  Files        2676     2676              
  Lines       82151    82257     +106     
  Branches    15539    15610      +71     
==========================================
+ Hits        27001    27018      +17     
- Misses      53048    53105      +57     
- Partials     2102     2134      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

willmartian
willmartian previously approved these changes Aug 26, 2024
Copy link
Contributor

@willmartian willmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me 👍

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for tackling all these changes!

@jaasen-livefront
Copy link
Collaborator Author

jaasen-livefront commented Aug 27, 2024

@JaredSnider-Bitwarden @willmartian Quick re-review please! Had to resolve a merge conflict and fix a few more missing toastService args.

@jaasen-livefront jaasen-livefront merged commit 9041a4c into main Aug 27, 2024
66 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-6564 branch August 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants