-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-6564] migrate auth toasts to CL toastService #10665
Conversation
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10665 +/- ##
==========================================
- Coverage 32.86% 32.84% -0.03%
==========================================
Files 2676 2676
Lines 82151 82257 +106
Branches 15539 15610 +71
==========================================
+ Hits 27001 27018 +17
- Misses 53048 53105 +57
- Partials 2102 2134 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thank you for tackling all these changes!
1250147
@JaredSnider-Bitwarden @willmartian Quick re-review please! Had to resolve a merge conflict and fix a few more missing toastService args. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-6564
📔 Objective
This PR migrates all auth toasts to the CL toastService
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes