Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-10937][PM-6644][AC-1810] Self-hosting section shows for Teams and Free orgs #10692

Merged

Conversation

cyprain-okeke
Copy link
Contributor

@cyprain-okeke cyprain-okeke commented Aug 23, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10937
https://bitwarden.atlassian.net/browse/PM-6644
https://bitwarden.atlassian.net/browse/AC-1810

📔 Objective

Both Free and Teams orgs are able to view the “self hosting” section in admin console > billing > subscription. Teams orgs are even able to download their license file.
Since neither Teams nor Free organizations can be self hosted, the section should be hidden for these org types to reduce visual clutter.

📸 Screenshots

Screen.Recording.2024-08-23.at.11.27.03.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cyprain-okeke cyprain-okeke added the needs-qa Marks a PR as requiring QA approval label Aug 23, 2024
@cyprain-okeke cyprain-okeke requested a review from a team as a code owner August 23, 2024 10:33
@cyprain-okeke cyprain-okeke changed the title [PM-10937] Self-hosting section shows for Teams and Free orgs [PM-10937][PM-6644] Self-hosting section shows for Teams and Free orgs Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.87%. Comparing base (6f8ad24) to head (4641ce1).
Report is 79 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tions/organization-subscription-cloud.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10692      +/-   ##
==========================================
- Coverage   32.87%   32.87%   -0.01%     
==========================================
  Files        2666     2666              
  Lines       81800    81803       +3     
  Branches    15444    15446       +2     
==========================================
  Hits        26895    26895              
- Misses      52809    52812       +3     
  Partials     2096     2096              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 23, 2024

Logo
Checkmarx One – Scan Summary & Details1c543057-5ef9-4629-8225-e335e41565c7

No New Or Fixed Issues Found

@cyprain-okeke cyprain-okeke changed the title [PM-10937][PM-6644] Self-hosting section shows for Teams and Free orgs [PM-10937][PM-6644][AC-1810] Self-hosting section shows for Teams and Free orgs Aug 23, 2024
@cyprain-okeke cyprain-okeke removed the needs-qa Marks a PR as requiring QA approval label Aug 30, 2024
@cyprain-okeke cyprain-okeke merged commit c0fbb5c into main Aug 30, 2024
35 of 40 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-10937-self-hosting-section-shows-for-teams-and-free-orgs branch August 30, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants