[PM-10993] Browser Refresh - Fix duplicate password generation emissions in Firefox

[shane-melton]

🎟️ Tracking

PM-10993

📔 Objective

The legacy password generation service implementation causes the state to be modified multiple times with a single save call. The upcoming replacement services from Tools will better support our use case here. So for now, I'm removing the call to save the password type option to the users settings in state. This avoids the multiple calls to update state and thus the repeated emissions (some outside of NgZone) that was causing unexpected behaviors.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – 16666026-027f-47ad-bedb-6decb45537bf

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 129	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 92	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/publish-desktop.yml: 124	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/publish-desktop.yml: 115	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 171	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
	Client_JQuery_Deprecated_Symbols	/libs/importer/src/services/import.service.ts: 455	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 141
	Unpinned Actions Full Length Commit SHA	/publish-desktop.yml: 245
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 104
	Unpinned Actions Full Length Commit SHA	/publish-desktop.yml: 122
	Unpinned Actions Full Length Commit SHA	/publish-desktop.yml: 196
	Unpinned Actions Full Length Commit SHA	/publish-cli.yml: 181

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.84%. Comparing base (1fe6631) to head (7d63498).
Report is 55 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10704      +/-   ##
==========================================
- Coverage   32.87%   32.84%   -0.04%     
==========================================
  Files        2665     2667       +2     
  Lines       81719    81905     +186     
  Branches    15417    15493      +76     
==========================================
+ Hits        26868    26898      +30     
- Misses      52771    52911     +140     
- Partials     2080     2096      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.