Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11314] Fix system auth typo 'autometic' -> 'automatic' #10708

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

larouxn
Copy link
Contributor

@larouxn larouxn commented Aug 24, 2024

🎟️ Tracking

I suppose this change is relevant to:

https://bitwarden.atlassian.net/browse/PM-990

as it's a follow up to:

📔 Objective

Trying to fix this autometic typo by updating it to automatic.

📸 Screenshots

Location of the typo is this modal that currently appears when toggling Unlock with system authentication on my Flatpak installation on my Fedora system.

Screenshot from 2024-08-24 09-38-00

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-11314

@bitwarden-bot bitwarden-bot changed the title Fix system auth typo 'autometic' -> 'automatic' [PM-11314] Fix system auth typo 'autometic' -> 'automatic' Aug 24, 2024
@quexten quexten self-assigned this Aug 24, 2024
@quexten
Copy link
Contributor

quexten commented Aug 24, 2024

Nice catch! Since flatpak currently does not have official support and snap was pulled for the release, QA had no chance of catching this. Thank you for the contribution!

@quexten quexten merged commit f468e62 into bitwarden:main Aug 26, 2024
20 of 25 checks passed
@larouxn larouxn deleted the fix_system_auth_typo branch August 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants