Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRE-246] - Use GH-App for Version Bump Workflow #10986

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Sep 11, 2024

🎟️ Tracking

📔 Objective

  • Use GH app as auto PR creator

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner September 11, 2024 10:03
@Eeebru Eeebru self-assigned this Sep 11, 2024
@Eeebru Eeebru added the hold do not merge, do not approve yet label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.07%. Comparing base (31a5aa9) to head (312d914).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10986   +/-   ##
=======================================
  Coverage   35.07%   35.07%           
=======================================
  Files        2693     2693           
  Lines       83871    83871           
  Branches    15941    15941           
=======================================
  Hits        29421    29421           
  Misses      53482    53482           
  Partials      968      968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Logo
Checkmarx One – Scan Summary & Details6d8fc624-3c8c-4076-8fc6-91e7fe23ac48

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 201 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 297 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 515 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 359 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 499 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 194 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 523 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 247 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 187 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 507 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 180 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 162 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 500
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 195
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 516
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 202
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 181
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 360
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 163
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 508
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 248
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 298
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 492
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 188

@Eeebru Eeebru removed the hold do not merge, do not approve yet label Sep 13, 2024
@Eeebru Eeebru requested a review from vgrassia September 16, 2024 15:02
@Eeebru Eeebru merged commit d34b407 into main Sep 16, 2024
20 checks passed
@Eeebru Eeebru deleted the BRE-246-Use-gh-App-for-auto-pr branch September 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants