Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-2718] Set nspasteboard.ConcealedType for clipboard on MacOS #11025

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Sep 13, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-2718

📔 Objective

We added support for setting exclude_from_history 1Password/arboard#159, which hides values from MacOS clipboard managers by setting org.nspasteboard.ConcealedType. This enables the use of exclude_from_history in our desktop application.

Resolves #2633.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner September 13, 2024 09:08
@Hinton Hinton requested a review from coroiu September 13, 2024 09:08
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.12%. Comparing base (1e76d23) to head (c1d6d03).
Report is 9 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11025   +/-   ##
=======================================
  Coverage   35.12%   35.12%           
=======================================
  Files        2691     2691           
  Lines       83754    83754           
  Branches    15915    15915           
=======================================
  Hits        29419    29419           
  Misses      53367    53367           
  Partials      968      968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details46922baf-297b-48fe-a83d-0e9dd15555c6

No New Or Fixed Issues Found

@Hinton Hinton merged commit 20d83ab into main Sep 16, 2024
38 checks passed
@Hinton Hinton deleted the ps/PM-PM-2718-pasteboard branch September 16, 2024 13:16
@Hinton Hinton mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasteboard type
2 participants