Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11487] Community PR: If an org has only one collection, check it by default #11084

Closed

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Sep 16, 2024

🎟️ Tracking

PM-11497

📔 Objective

PR to build artifiacts for Community PR

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jingo88 Jingo88 added the hold do not merge, do not approve yet label Sep 16, 2024
@Jingo88 Jingo88 requested a review from a team as a code owner September 16, 2024 15:47
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.98%. Comparing base (1c43402) to head (020851c).
Report is 361 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...angular/src/vault/components/add-edit.component.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11084      +/-   ##
==========================================
+ Coverage   33.15%   34.98%   +1.83%     
==========================================
  Files        2684     2694      +10     
  Lines       82868    84094    +1226     
  Branches    15722    15987     +265     
==========================================
+ Hits        27476    29424    +1948     
- Misses      53235    53701     +466     
+ Partials     2157      969    -1188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jingo88
Copy link
Contributor Author

Jingo88 commented Oct 7, 2024

Community PR merged. Closing this temp PR.

@Jingo88 Jingo88 closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants