-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PM-12102 | Fix LastPass importer not properly de-encrypting URLs #11366
Conversation
TODO: Add a test for the folder case! | ||
TODO: Add a test case that covers secure note account! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also couldn't find any existing tests for this parser. Should I leave it like that or add them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally you would add them. In the meantime I'm going to approve and move this to QA, so we can hopefully include the fix soon.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11366 +/- ##
==========================================
+ Coverage 33.24% 33.26% +0.02%
==========================================
Files 2728 2728
Lines 85392 85413 +21
Branches 16275 16278 +3
==========================================
+ Hits 28387 28414 +27
+ Misses 54755 54749 -6
Partials 2250 2250 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
Spoke with QA and merging this, to be included with the |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12102
Closes #11051
📔 Objective
LastPass encrypts URLs of items in their vault. When importing, they need to be decrypted to appear properly.
I used this code as reference for my implementation.
📸 Screenshots
Before:
After:
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes