Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14370] Extension Auth Page Padding #11869

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Nov 5, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14370

📔 Objective

Adjusts the spacing in AnonLayout to align with Figma. The Jira tasks asked for the following:

  • Update AnonLayout horizontal padding to be 1.5rem
  • Use disablePadding option for extension layouts that use AnonLayout
    • This allowed me to remove the decreaseTopPadding input entirely from the ExtensionAnonLayout because it also removes top padding.

In addition, I also noticed a few more areas where code did not match design, so I updated the following, using this Figma as a reference:

  • Updated the space from top of screen to the Bitwarden logo to be 1.5 rem (24px)
  • Updated the space from the Bitwarden logo to the icon to be 3rem (48px)
  • Updated the space from the Icon/Title/Subtitle section to the main content section to be 1.5rem (24px)
  • Updated the space from the main content section to the secondary content section to be 2.5rem (40px)

🎨 Storybook Review

https://www.chromatic.com/review?appId=62a88a6de5b807fa98886113&number=11869&type=linked

📸 Screenshots

web extension desktop

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@rr-bw rr-bw marked this pull request as ready for review November 5, 2024 18:28
@rr-bw rr-bw requested a review from a team as a code owner November 5, 2024 18:28
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.48%. Comparing base (7ef1d01) to head (2e253a5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11869   +/-   ##
=======================================
  Coverage   33.48%   33.48%           
=======================================
  Files        2844     2844           
  Lines       89023    89022    -1     
  Branches    16980    16980           
=======================================
  Hits        29807    29807           
+ Misses      56873    56872    -1     
  Partials     2343     2343           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jtouchstonebw jtouchstonebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details96bcd517-dff1-4b7a-876e-bffb322ec910

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 876

@rr-bw rr-bw merged commit 204eb31 into main Nov 13, 2024
72 checks passed
@rr-bw rr-bw deleted the auth/pm-14370/extension-auth-page-padding branch November 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants