Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12399] Show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher #11913

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jprusik
Copy link
Contributor

@jprusik jprusik commented Nov 7, 2024

🎟️ Tracking

PM-12399

📔 Objective

Show card and identity ciphers in the autofill suggestions only if the active tab appears to have fields for that type of cipher

📸 Screenshots

Kapture.2024-11-07.at.18.23.20.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jprusik jprusik self-assigned this Nov 7, 2024

This comment was marked as off-topic.

@jprusik jprusik marked this pull request as ready for review November 8, 2024 18:16
@jprusik jprusik requested a review from a team as a code owner November 8, 2024 18:16
@jprusik jprusik requested a review from gbubemismith November 8, 2024 18:16
coltonhurst
coltonhurst previously approved these changes Nov 8, 2024
Jingo88
Jingo88 previously approved these changes Nov 11, 2024
@jprusik
Copy link
Contributor Author

jprusik commented Nov 11, 2024

working on a fix for the test failure

resolved in 6dc73b8

danielleflinn
danielleflinn previously approved these changes Nov 12, 2024
gbubemismith
gbubemismith previously approved these changes Nov 12, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (204eb31) to head (6dc73b8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ult/popup/services/vault-popup-autofill.service.ts 25.00% 14 Missing and 1 partial ⚠️
apps/browser/src/background/main.background.ts 0.00% 1 Missing ⚠️
apps/browser/src/popup/services/services.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11913      +/-   ##
==========================================
- Coverage   33.47%   33.47%   -0.01%     
==========================================
  Files        2844     2844              
  Lines       89022    89044      +22     
  Branches    16980    16987       +7     
==========================================
+ Hits        29803    29805       +2     
- Misses      56876    56894      +18     
- Partials     2343     2345       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jprusik jprusik merged commit 3a293bb into main Nov 13, 2024
27 checks passed
@jprusik jprusik deleted the pm-12399 branch November 13, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants