Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14019] Toggle Vault Filters #11929

Merged
merged 27 commits into from
Nov 19, 2024

Merge branch 'main' of https://github.com/bitwarden/clients into vaul…

83d3cb3
Select commit
Loading
Failed to load commit list.
Merged

[PM-14019] Toggle Vault Filters #11929

Merge branch 'main' of https://github.com/bitwarden/clients into vaul…
83d3cb3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

33.50% (+0.06%) compared to 40f2e15

View this Pull Request on Codecov

33.50% (+0.06%) compared to 40f2e15

Details

Codecov Report

Attention: Patch coverage is 81.25000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 33.50%. Comparing base (40f2e15) to head (83d3cb3).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/src/disclosure/disclosure.component.ts 0.00% 5 Missing ⚠️
...vault-v2/vault-header/vault-header-v2.component.ts 94.28% 0 Missing and 2 partials ⚠️
...vault/popup/components/vault/vault-v2.component.ts 0.00% 1 Missing ⚠️
...popup/services/vault-popup-list-filters.service.ts 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11929      +/-   ##
==========================================
+ Coverage   33.44%   33.50%   +0.06%     
==========================================
  Files        2844     2845       +1     
  Lines       89043    89087      +44     
  Branches    16982    16988       +6     
==========================================
+ Hits        29777    29851      +74     
+ Misses      56929    56894      -35     
- Partials     2337     2342       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov