Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14019] Toggle Vault Filters #11929

Merged
merged 27 commits into from
Nov 19, 2024

Merge branch 'main' into vault/pm-14019/hide-vault-filters

440e37f
Select commit
Loading
Failed to load commit list.
Merged

[PM-14019] Toggle Vault Filters #11929

Merge branch 'main' into vault/pm-14019/hide-vault-filters
440e37f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 19, 2024 in 1s

33.52% (+0.06%) compared to c17f582

View this Pull Request on Codecov

33.52% (+0.06%) compared to c17f582

Details

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (c17f582) to head (440e37f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../components/src/disclosure/disclosure.component.ts 0.00% 5 Missing ⚠️
...vault-v2/vault-header/vault-header-v2.component.ts 96.29% 0 Missing and 1 partial ⚠️
...vault/popup/components/vault/vault-v2.component.ts 0.00% 1 Missing ⚠️
...popup/services/vault-popup-list-filters.service.ts 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11929      +/-   ##
==========================================
+ Coverage   33.46%   33.52%   +0.06%     
==========================================
  Files        2858     2859       +1     
  Lines       89396    89434      +38     
  Branches    17018    17022       +4     
==========================================
+ Hits        29919    29986      +67     
+ Misses      57120    57087      -33     
- Partials     2357     2361       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov