-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TokenService
More Observable
#11973
base: main
Are you sure you want to change the base?
Conversation
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11973 +/- ##
==========================================
+ Coverage 33.44% 33.50% +0.06%
==========================================
Files 2844 2844
Lines 89043 89030 -13
Branches 16982 16976 -6
==========================================
+ Hits 29777 29829 +52
+ Misses 56929 56861 -68
- Partials 2337 2340 +3 ☔ View full report in Codecov by Sentry. |
On pause until I think about the fact that chrome does not do a |
🎟️ Tracking
📔 Objective
This is just one small part of what I was talking about in this slack thread today. I want a
AuthService
method that retrieves an observable of "AuthPackages" like:In order to do that though, we would need an observable way to get the current
accessToken
. This adds that.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes