Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14861]Vault items fail to load #11974

Conversation

cyprain-okeke
Copy link
Contributor

@cyprain-okeke cyprain-okeke commented Nov 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14860
https://bitwarden.atlassian.net/browse/PM-14861

📔 Objective

Tested using MSP client org. I sent an invite to a new Owner role in Client Org and after I confirmed the Owner, it got kicked out of the app and cannot log in after that.

📸 Screenshots

Uploading Screen Recording 2024-11-12 at 21.50.20.mov…

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Logo
Checkmarx One – Scan Summary & Details262c1a97-7964-47c7-acd0-10cddb195459

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 269
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 121
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 194
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 50
MEDIUM Unpinned Actions Full Length Commit SHA /version-auto-bump.yml: 40
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 187
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 421
MEDIUM Unpinned Actions Full Length Commit SHA /publish-web.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 40
MEDIUM Unpinned Actions Full Length Commit SHA /crowdin-pull.yml: 34
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 43
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 167
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 416
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 70
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 204
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 195
MEDIUM Unpinned Actions Full Length Commit SHA /release-cli.yml: 58
MEDIUM Unpinned Actions Full Length Commit SHA /staged-rollout-desktop.yml: 28
MEDIUM Unpinned Actions Full Length Commit SHA /retrieve-current-desktop-rollout.yml: 22
MEDIUM Unpinned Actions Full Length Commit SHA /brew-bump-desktop.yml: 25
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1319
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 362
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 372
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 283
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 372
MEDIUM Unpinned Actions Full Length Commit SHA /publish-desktop.yml: 244
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 140
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 667
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 254
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 208
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 915
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 314
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1368
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop-beta.yml: 247
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 103
MEDIUM Unpinned Actions Full Length Commit SHA /release-browser.yml: 95
MEDIUM Unpinned Actions Full Length Commit SHA /release-web.yml: 56
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 114
MEDIUM Unpinned Actions Full Length Commit SHA /release-web.yml: 40
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 305
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 221
MEDIUM Unpinned Actions Full Length Commit SHA /deploy-web.yml: 190
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 306
MEDIUM Unpinned Actions Full Length Commit SHA /repository-management.yml: 201
MEDIUM Unpinned Actions Full Length Commit SHA /publish-cli.yml: 180
MEDIUM Unpinned Actions Full Length Commit SHA /release-desktop.yml: 93
MEDIUM Unpinned Actions Full Length Commit SHA /release-browser.yml: 43

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (84b2b02) to head (1ae6acf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 7 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 6 Missing ⚠️
...response/organization-billing-metadata.response.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11974      +/-   ##
==========================================
- Coverage   33.48%   33.48%   -0.01%     
==========================================
  Files        2845     2845              
  Lines       89046    89056      +10     
  Branches    16982    16983       +1     
==========================================
  Hits        29817    29817              
- Misses      56889    56899      +10     
  Partials     2340     2340              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyprain-okeke cyprain-okeke requested a review from a team as a code owner November 12, 2024 20:12
@cyprain-okeke cyprain-okeke removed request for a team and jrmccannon November 12, 2024 20:13
@github-actions github-actions bot temporarily deployed to Web Vault - EU QA Cloud November 13, 2024 01:22 Inactive
@cyprain-okeke cyprain-okeke removed the request for review from Jingo88 November 13, 2024 10:50
@github-actions github-actions bot temporarily deployed to Web Vault - US QA Cloud November 13, 2024 11:49 Inactive
@cyprain-okeke cyprain-okeke enabled auto-merge (squash) November 13, 2024 12:19
@cyprain-okeke cyprain-okeke merged commit 24ca942 into main Nov 13, 2024
69 checks passed
@cyprain-okeke cyprain-okeke deleted the pm-14860-invited-owner-in-client-org-cannot-log-in-the-web-app-after-confirmation branch November 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants