Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14895] Add autofocus to search field on Send page #11979

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Nov 13, 2024

🎟️ Tracking

PM-14895

📔 Objective

Add autofocus to search field on Send page.

📸 Screenshots

Screen.Recording.2024-11-13.at.11.21.44.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner November 13, 2024 10:29
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.49%. Comparing base (c496792) to head (5dba3eb).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11979   +/-   ##
=======================================
  Coverage   33.48%   33.49%           
=======================================
  Files        2845     2845           
  Lines       89046    89046           
  Branches    16982    16982           
=======================================
+ Hits        29817    29824    +7     
+ Misses      56889    56882    -7     
  Partials     2340     2340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0f886975-f369-4e5f-9b0b-ca8898373009

No New Or Fixed Issues Found

Copy link
Member

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM. Was the disabled warning always showing before?

📝 I'm not used to seeing the password manager localized to de, so at first glance I thought the "Password" selector was having a layout issue. 😆

@djsmith85 djsmith85 merged commit e341a66 into main Nov 13, 2024
73 checks passed
@djsmith85 djsmith85 deleted the tools/pm-14895/send-autofocus-search-field branch November 13, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants