Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14901] Fix ssh keys being empty when creating while filter is active #11985

Merged
merged 2 commits into from
Nov 20, 2024

Merge branch 'main' into km/pm-14901/ssh-key-creation-broken-with-filter

5aff067
Select commit
Loading
Failed to load commit list.
Merged

[PM-14901] Fix ssh keys being empty when creating while filter is active #11985

Merge branch 'main' into km/pm-14901/ssh-key-creation-broken-with-filter
5aff067
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 13, 2024 in 0s

33.46% (-0.02%) compared to 0cfe18a

View this Pull Request on Codecov

33.46% (-0.02%) compared to 0cfe18a

Details

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.46%. Comparing base (0cfe18a) to head (5aff067).

โœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../desktop/src/vault/app/vault/add-edit.component.ts 0.00% 8 Missing โš ๏ธ
libs/common/src/vault/models/view/ssh-key.view.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11985      +/-   ##
==========================================
- Coverage   33.48%   33.46%   -0.02%     
==========================================
  Files        2844     2844              
  Lines       89044    89052       +8     
  Branches    16987    16992       +5     
==========================================
- Hits        29812    29805       -7     
- Misses      56887    56902      +15     
  Partials     2345     2345              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.