Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9111] Extension: persist add/edit form #12236

Merged
merged 25 commits into from
Jan 22, 2025

add services to cipher form storybook

7b12559
Select commit
Loading
Failed to load commit list.
Merged

[PM-9111] Extension: persist add/edit form #12236

add services to cipher form storybook
7b12559
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 4, 2024 in 0s

33.54% (+0.02%) compared to a6c905c

View this Pull Request on Codecov

33.54% (+0.02%) compared to a6c905c

Details

Codecov Report

Attention: Patch coverage is 57.50000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.54%. Comparing base (a6c905c) to head (7b12559).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/cipher-form/components/cipher-form.component.ts 5.88% 16 Missing ⚠️
libs/vault/src/cipher-form/cipher-form.stories.ts 0.00% 7 Missing ⚠️
...her-form/components/identity/identity.component.ts 0.00% 4 Missing ⚠️
...nts/item-details/item-details-section.component.ts 69.23% 0 Missing and 4 partials ⚠️
...rm/services/popup-view-cache-background.service.ts 0.00% 2 Missing ⚠️
...form/services/default-cipher-form-cache.service.ts 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12236      +/-   ##
==========================================
+ Coverage   33.51%   33.54%   +0.02%     
==========================================
  Files        2886     2887       +1     
  Lines       90183    90211      +28     
  Branches    17149    17145       -4     
==========================================
+ Hits        30229    30259      +30     
+ Misses      57564    57560       -4     
- Partials     2390     2392       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov