Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-9111] Extension: persist add/edit form #12236

Merged
merged 25 commits into from
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
83b8a0b
remove todo
nick-livefront Dec 3, 2024
69753d2
Retrieve cache cipher for add-edit form
nick-livefront Dec 3, 2024
7823c00
user prefilled cipher for add-edit form
nick-livefront Dec 3, 2024
feba423
add listener for clearing view cache
nick-livefront Dec 3, 2024
fd38a8c
clear local cache when clearing global state
nick-livefront Dec 3, 2024
fed1991
track initial value of cache for down stream logic that should only oโ€ฆ
nick-livefront Dec 3, 2024
d85f7f4
add feature flag for edit form persistence
nick-livefront Dec 3, 2024
388b1f2
add tests for cipher form cache service
nick-livefront Dec 4, 2024
2f59a3d
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Dec 4, 2024
3f6374f
fix optional initialValues
nick-livefront Dec 4, 2024
7b12559
add services to cipher form storybook
nick-livefront Dec 4, 2024
0720a9d
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Dec 12, 2024
00266fd
fix strict types
nick-livefront Dec 12, 2024
cb5d689
rename variables to be platform agnostic
nick-livefront Dec 12, 2024
7ef3a7b
use deconstructed collectionIds variable to avoid them be overwritten
nick-livefront Dec 12, 2024
77c0c19
use the originalCipherView for initial values
nick-livefront Dec 13, 2024
5c0a399
add comment about signal equality
nick-livefront Dec 13, 2024
6736292
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Dec 19, 2024
1335c3a
Merge branch 'main' into vault/pm-9111/persist-add-edit
nick-livefront Jan 2, 2025
e8b9bf6
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Jan 14, 2025
af9dc2e
prevent events from being emitted when adding uris to the existing form
nick-livefront Jan 14, 2025
b8b8c2c
add check for cached cipher when adding initial uris
nick-livefront Jan 14, 2025
e8188f8
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Jan 14, 2025
a4a6d2d
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Jan 17, 2025
42c1ffd
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
nick-livefront Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' of https://github.com/bitwarden/clients into vaulโ€ฆ
โ€ฆt/pm-9111/persist-add-edit
nick-livefront committed Jan 22, 2025
commit 42c1ffd36900f35c4cbdc0c99964aa600a1ae911
2 changes: 0 additions & 2 deletions libs/common/src/enums/feature-flag.enum.ts
Original file line number Diff line number Diff line change
@@ -45,7 +45,6 @@ export enum FeatureFlag {
DisableFreeFamiliesSponsorship = "PM-12274-disable-free-families-sponsorship",
MacOsNativeCredentialSync = "macos-native-credential-sync",
PM9111ExtensionPersistAddEditForm = "pm-9111-extension-persist-add-edit-form",
PM12443RemovePagingLogic = "pm-12443-remove-paging-logic",
PrivateKeyRegeneration = "pm-12241-private-key-regeneration",
ResellerManagedOrgAlert = "PM-15814-alert-owners-of-reseller-managed-orgs",
}
@@ -103,7 +102,6 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.DisableFreeFamiliesSponsorship]: FALSE,
[FeatureFlag.MacOsNativeCredentialSync]: FALSE,
[FeatureFlag.PM9111ExtensionPersistAddEditForm]: FALSE,
[FeatureFlag.PM12443RemovePagingLogic]: FALSE,
[FeatureFlag.PrivateKeyRegeneration]: FALSE,
[FeatureFlag.ResellerManagedOrgAlert]: FALSE,
} satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>;
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.