[PM-15584] Fix autoprompt safari process reload #12352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9823/extract-biometric-messaging-service
Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Maciej Zieniuk <[email protected]>
…9823/extract-biometric-messaging-service
…9823/extract-biometric-messaging-service
…den/clients into km/pm-15584/fix-safari-biometrics
quexten
dismissed stale reviews from JaredSnider-Bitwarden and mzieniukbw
The base branch was changed.
…den/clients into km/pm-15584/fix-safari-biometrics
dani-garcia
approved these changes
Jan 9, 2025
mzieniukbw
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15584
📔 Objective
Fixes safari's autoprompting behavior. Safari does not close the browser window on lock, instead it just reloads the webpage. The fix is to simply write the last process reload date to state, and then if there was a process reload within the last INTERVAL (5 seconds), do not autoprompt.
📸 Screenshots
Screen.Recording.2024-12-11.at.15.53.42.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes