-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-12985] - Updating reports to use new modal for view/edit cipher #12383
base: main
Are you sure you want to change the base?
Conversation
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cd-bitwarden: Overall the changes are looking good. Just one thing about the missing reprompt and the tests are currently failing. Then this should be good to go
apps/web/src/app/tools/reports/pages/cipher-report.component.ts
Outdated
Show resolved
Hide resolved
2c55e27
Auth change is fine, but there are some failing lint/test checks.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12985
📔 Objective
Updating reports to use new modal for view/edit cipher
dialog
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes