Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12985] - Updating reports to use new modal for view/edit cipher #12383

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

cd-bitwarden
Copy link
Contributor

@cd-bitwarden cd-bitwarden commented Dec 12, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12985

📔 Objective

Updating reports to use new modal for view/edit cipher
dialog

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cd-bitwarden cd-bitwarden requested review from a team as code owners December 12, 2024 20:37
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Logo
Checkmarx One – Scan Summary & Details80670111-907c-4f86-88f9-76df8a722c72

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cd-bitwarden: Overall the changes are looking good. Just one thing about the missing reprompt and the tests are currently failing. Then this should be good to go

@djsmith85 djsmith85 removed the request for review from a team December 20, 2024 14:14
JimmyVo16
JimmyVo16 previously approved these changes Dec 31, 2024
@cd-bitwarden cd-bitwarden requested a review from a team as a code owner January 8, 2025 21:56
@cd-bitwarden cd-bitwarden requested a review from Jingo88 January 8, 2025 21:56
@djsmith85 djsmith85 requested a review from Jingo88 January 14, 2025 16:43
Jingo88
Jingo88 previously approved these changes Jan 14, 2025
JimmyVo16
JimmyVo16 previously approved these changes Jan 14, 2025
@addisonbeck addisonbeck removed their request for review January 21, 2025 19:27
@cd-bitwarden cd-bitwarden dismissed stale reviews from djsmith85, JimmyVo16, and Jingo88 via 2c55e27 January 22, 2025 22:00
@cd-bitwarden cd-bitwarden requested a review from a team as a code owner January 23, 2025 00:00
@cd-bitwarden cd-bitwarden requested a review from rr-bw January 23, 2025 00:00
rr-bw
rr-bw previously approved these changes Jan 23, 2025
@rr-bw rr-bw dismissed their stale review January 23, 2025 19:37

Auth change is fine, but there are some failing lint/test checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants