Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-14416] Risk Insights - Initial security task service #12446

Merged
merged 11 commits into from
Jan 21, 2025

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Dec 17, 2024

🎟️ Tracking

PM-14416

📔 Objective

Introduce the initial default implementation of the security task service - TaskService and DefaultTaskService.

Also tweaks the ApiService to support PATCH requests and 204 No Content response statuses.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@shane-melton shane-melton requested review from a team as code owners December 17, 2024 19:16
Copy link
Contributor

github-actions bot commented Dec 17, 2024

Logo
Checkmarx One – Scan Summary & Details1472f318-e802-4af5-bbc8-57550650c6e1

No New Or Fixed Issues Found

coroiu
coroiu previously approved these changes Dec 18, 2024
gbubemismith
gbubemismith previously approved these changes Dec 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Thanks for creating this

@shane-melton shane-melton dismissed stale reviews from gbubemismith and coroiu via 4c4cceb December 31, 2024 22:11
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 94.79167% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8cabb36). Learn more about missing BASE report.
Report is 142 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/vault/src/tasks/services/default-task.service.ts 94.73% 0 Missing and 2 partials ⚠️
libs/common/src/services/api.service.ts 0.00% 1 Missing ⚠️
libs/vault/src/tasks/models/security-task.data.ts 88.88% 1 Missing ⚠️
libs/vault/src/tasks/state/security-task.state.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12446   +/-   ##
=======================================
  Coverage        ?   34.21%           
=======================================
  Files           ?     2949           
  Lines           ?    90510           
  Branches        ?    16992           
=======================================
  Hits            ?    30966           
  Misses          ?    57084           
  Partials        ?     2460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new platform changes, approving!

@shane-melton shane-melton merged commit 5e1d5ba into main Jan 21, 2025
88 checks passed
@shane-melton shane-melton deleted the vault/pm-14416/initial-task-service branch January 21, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants