Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13737] Fix installation ID missing in events by returning an object with the 'name' property instead of a string #12463

Conversation

r-tome
Copy link
Contributor

@r-tome r-tome commented Dec 18, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13737

📔 Objective

When a F4E sponsorship sync happens, an event is logged in the corresponding Cloud organization, but the installation ID is not included in that event log

The issue occurred because the getUserName method was expected to return an object, but it returned a string when handling the installation ID.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@r-tome r-tome marked this pull request as ready for review December 18, 2024 14:47
@r-tome r-tome requested a review from a team as a code owner December 18, 2024 14:47
@r-tome r-tome requested a review from JimmyVo16 December 18, 2024 14:47
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details267db5e6-c590-49a1-908c-9d3b4bfc42b6

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 878

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (903b5c8) to head (3afbb09).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...n-console/organizations/manage/events.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12463      +/-   ##
==========================================
- Coverage   33.52%   33.52%   -0.01%     
==========================================
  Files        2915     2915              
  Lines       91107    91107              
  Branches    17343    17343              
==========================================
- Hits        30548    30541       -7     
- Misses      58153    58160       +7     
  Partials     2406     2406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-tome r-tome added the needs-qa Marks a PR as requiring QA approval label Jan 2, 2025
@vincentsalucci vincentsalucci removed the needs-qa Marks a PR as requiring QA approval label Jan 3, 2025
@vincentsalucci vincentsalucci merged commit 196c1e1 into main Jan 3, 2025
38 of 39 checks passed
@vincentsalucci vincentsalucci deleted the ac/pm-13737/install-id-not-included-when-sponsorship-sync-occurs branch January 3, 2025 20:36
@vincentsalucci
Copy link
Member

Merged to main via request from QA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants